Skip to content

Redefine WithProjectionOf as an extension to Specification instead of ISpecification#517

Merged
fiseni merged 1 commit into
mainfrom
fiseni/withprojectionof-refactoring
Jun 14, 2025
Merged

Redefine WithProjectionOf as an extension to Specification instead of ISpecification#517
fiseni merged 1 commit into
mainfrom
fiseni/withprojectionof-refactoring

Conversation

@fiseni

@fiseni fiseni commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator

Fixes #516

@fiseni fiseni requested a review from Copilot June 14, 2025 15:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the projection extension and internal state copying by removing the old CopyTo hook on ISpecification<T>, introducing a Clone API on Specification<T>, and updating WithProjectionOf to leverage Clone<TResult>. It also cleans up unused explicit interface implementations in custom spec test classes and adds tests for the new Clone methods.

  • Removed ISpecification<T>.CopyTo and related explicit implementations in test fixtures
  • Added Clone() and Clone<TResult>() (with a shared CopyState helper) in Specification<T>
  • Updated SpecificationExtensions.WithProjectionOf to accept Specification<T> and use Clone<TResult>
  • Introduced unit tests verifying Clone behavior

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Ardalis.Specification.Tests/Validators/SearchValidatorCustomSpecTests.cs Removed unused ISpecification<T>.CopyTo impl
tests/Ardalis.Specification.Tests/Evaluators/SearchMemoryEvaluatorCustomSpecTests.cs Removed unused ISpecification<T>.CopyTo impl
tests/Ardalis.Specification.EntityFrameworkCore.Tests/Evaluators/SearchEvaluatorCustomSpecTests.cs Removed unused ISpecification<T>.CopyTo impl
tests/Ardalis.Specification.Tests/SpecificationTests.cs Added Clone and Clone<TResult> unit tests
src/Ardalis.Specification/SpecificationExtensions.cs Changed WithProjectionOf to accept Specification<T> and use Clone<TResult>
src/Ardalis.Specification/Specification.cs Introduced Clone(), Clone<TResult>(), and CopyState helper
src/Ardalis.Specification/ISpecification.cs Removed internal void CopyTo member
Comments suppressed due to low confidence (2)

src/Ardalis.Specification/SpecificationExtensions.cs:20

  • Changing WithProjectionOf to only accept Specification<T> is a breaking API change. Consider documenting this in the changelog and updating XML docs to guide consumers through the new usage.
public static Specification<T, TResult> WithProjectionOf<T, TResult>(this Specification<T> source, Specification<T, TResult> projectionSpec)

tests/Ardalis.Specification.Tests/SpecificationTests.cs:21

  • [nitpick] There are no unit tests covering the new WithProjectionOf extension. Adding a test to verify that projection selectors and post-processing actions are correctly copied would increase confidence in this change.
[Fact]

@fiseni fiseni merged commit f37fb7e into main Jun 14, 2025
1 check passed
@fiseni fiseni deleted the fiseni/withprojectionof-refactoring branch June 14, 2025 15:12
This was referenced Aug 20, 2025
gritcsenko added a commit to gritcsenko/HomeInventory that referenced this pull request Aug 24, 2025
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
|
[Ardalis.Specification](https://redirect.github.com/ardalis/specification)
| `9.2.0` -> `9.3.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Ardalis.Specification/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Ardalis.Specification/9.2.0/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ardalis/specification (Ardalis.Specification)</summary>

###
[`v9.3.0`](https://redirect.github.com/ardalis/Specification/releases/tag/v9.3.0)

#### What's Changed

- Avoid List allocation for PostProcessingAction. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#501](https://redirect.github.com/ardalis/Specification/pull/501)
- Redefine WithProjectionOf as an extension to Specification instead of
ISpecification by [@&#8203;fiseni](https://redirect.github.com/fiseni)
in
[ardalis/Specification#517](https://redirect.github.com/ardalis/Specification/pull/517)
- Rename TagWithEvaluator to QueryTagEvaluator. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#512](https://redirect.github.com/ardalis/Specification/pull/512)
- OneOrMany implementation by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#507](https://redirect.github.com/ardalis/Specification/pull/507)
- Refactor the state of where expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#508](https://redirect.github.com/ardalis/Specification/pull/508)
- Refactor the state of order expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#509](https://redirect.github.com/ardalis/Specification/pull/509)
- Refactor the state of include expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#510](https://redirect.github.com/ardalis/Specification/pull/510)
- Refactor the state of search expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#511](https://redirect.github.com/ardalis/Specification/pull/511)
- Consolidate OneOrMany implementation and its usage. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#513](https://redirect.github.com/ardalis/Specification/pull/513)
- Add a fallback to LINQ for search evaluators/validator in case of
custom user specifications. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#514](https://redirect.github.com/ardalis/Specification/pull/514)
- Update dependencies. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#526](https://redirect.github.com/ardalis/Specification/pull/526)
- Use opencover format for coverage reports. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#503](https://redirect.github.com/ardalis/Specification/pull/503)
- Added Full Build workflow that publishes coverage reports. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#504](https://redirect.github.com/ardalis/Specification/pull/504)
- Add benchmarks project. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#505](https://redirect.github.com/ardalis/Specification/pull/505)
- Cleanup by [@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#518](https://redirect.github.com/ardalis/Specification/pull/518)
- Add new test fixtures for EF6 provider. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#519](https://redirect.github.com/ardalis/Specification/pull/519)
- Add tests for EF6 evaluators. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#520](https://redirect.github.com/ardalis/Specification/pull/520)

**Full Changelog**:
<ardalis/Specification@v9.2.0...v9.3.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/gritcsenko/HomeInventory).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4yIiwidXBkYXRlZEluVmVyIjoiNDEuODIuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
gritcsenko added a commit to gritcsenko/HomeInventory that referenced this pull request Aug 24, 2025
…1239)

This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
|
[Ardalis.Specification.EntityFrameworkCore](https://redirect.github.com/ardalis/specification)
| `9.2.0` -> `9.3.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Ardalis.Specification.EntityFrameworkCore/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Ardalis.Specification.EntityFrameworkCore/9.2.0/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ardalis/specification
(Ardalis.Specification.EntityFrameworkCore)</summary>

###
[`v9.3.0`](https://redirect.github.com/ardalis/Specification/releases/tag/v9.3.0)

#### What's Changed

- Avoid List allocation for PostProcessingAction. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#501](https://redirect.github.com/ardalis/Specification/pull/501)
- Redefine WithProjectionOf as an extension to Specification instead of
ISpecification by [@&#8203;fiseni](https://redirect.github.com/fiseni)
in
[ardalis/Specification#517](https://redirect.github.com/ardalis/Specification/pull/517)
- Rename TagWithEvaluator to QueryTagEvaluator. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#512](https://redirect.github.com/ardalis/Specification/pull/512)
- OneOrMany implementation by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#507](https://redirect.github.com/ardalis/Specification/pull/507)
- Refactor the state of where expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#508](https://redirect.github.com/ardalis/Specification/pull/508)
- Refactor the state of order expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#509](https://redirect.github.com/ardalis/Specification/pull/509)
- Refactor the state of include expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#510](https://redirect.github.com/ardalis/Specification/pull/510)
- Refactor the state of search expressions as OneOrMany. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#511](https://redirect.github.com/ardalis/Specification/pull/511)
- Consolidate OneOrMany implementation and its usage. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#513](https://redirect.github.com/ardalis/Specification/pull/513)
- Add a fallback to LINQ for search evaluators/validator in case of
custom user specifications. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#514](https://redirect.github.com/ardalis/Specification/pull/514)
- Update dependencies. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#526](https://redirect.github.com/ardalis/Specification/pull/526)
- Use opencover format for coverage reports. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#503](https://redirect.github.com/ardalis/Specification/pull/503)
- Added Full Build workflow that publishes coverage reports. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#504](https://redirect.github.com/ardalis/Specification/pull/504)
- Add benchmarks project. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#505](https://redirect.github.com/ardalis/Specification/pull/505)
- Cleanup by [@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#518](https://redirect.github.com/ardalis/Specification/pull/518)
- Add new test fixtures for EF6 provider. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#519](https://redirect.github.com/ardalis/Specification/pull/519)
- Add tests for EF6 evaluators. by
[@&#8203;fiseni](https://redirect.github.com/fiseni) in
[ardalis/Specification#520](https://redirect.github.com/ardalis/Specification/pull/520)

**Full Changelog**:
<ardalis/Specification@v9.2.0...v9.3.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/gritcsenko/HomeInventory).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4yIiwidXBkYXRlZEluVmVyIjoiNDEuODIuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This was referenced May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redefine WithProjectionOf as an extension to Specification instead of ISpecification

2 participants