Created async overload for clausules that use a predicate#228
Merged
Conversation
Contributor
Author
|
I made GetCustomStruct public. There was a build error for this. |
Reapism
suggested changes
Nov 21, 2022
There was a problem hiding this comment.
Great job @danny-bos-developer for creating easy to read, and succinct unit tests. This could be a great fail early scenario generally speaking.
Small suggestion... I would rename the method to be called ExpressionAsync instead of AgainstExpressionAsync since this is extending off the IGuardClause of this library, and the only entry point to this method is via the Against property so it is already explicit via usage of the library.
Great addition! Cheers.
Contributor
|
@Reapism Thanks Antony and I agree with your suggestion to remove Guard from the method. I only cannot edit any files in my PR. Some assistance or guidance would be appreciated. |
Contributor
Author
|
I need some TLC for this PR please |
|
@danny-bos-developer are you not able to edit the pull request? |
Contributor
Owner
|
I'll get it sorted |
Contributor
|
Alright, thank you. You probably need to remerge with the master again too because JetBrains has been removed.
Kind regards
Danny
From: Steve Smith ***@***.***>
Sent: Thursday, February 16, 2023 3:12 PM
To: ardalis/GuardClauses ***@***.***>
Cc: Bos, Danny ***@***.***>; Comment ***@***.***>
Subject: Re: [ardalis/GuardClauses] Created async overload for clausules that use a predicate (PR #228)
External email
I'll get it sorted
—
Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fardalis%2FGuardClauses%2Fpull%2F228%23issuecomment-1433150046&data=05%7C01%7Cdanny.bos%40tatasteeleurope.com%7C271a3c02565943b6816908db1027c717%7C44bbd632fe0442d7933e2649dcd22649%7C0%7C0%7C638121535253189682%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=L5woDxhcpWRBkoYf%2BZfKElFgSIjlNtAvGvyDr%2BcD%2B78%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJQYIVR5LOM2DLHFQ2ZHJJ3WXYYTFANCNFSM6AAAAAAQQ4PFUU&data=05%7C01%7Cdanny.bos%40tatasteeleurope.com%7C271a3c02565943b6816908db1027c717%7C44bbd632fe0442d7933e2649dcd22649%7C0%7C0%7C638121535253189682%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gl1vidUk51i0%2FRVsSJ3q3bSSPpdhKFEapXX0Kh4C8jI%3D&reserved=0>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
**********************************************************************
This transmission is confidential and must not be used or disclosed by anyone other than the intended recipient. Neither Tata Steel Europe Limited nor any of its subsidiaries can accept any responsibility for any use or misuse of the transmission by anyone.
For address and company registration details of certain entities within the Tata Steel Europe group of companies, please visit https://www.tatasteeleurope.com/en/legal-notice/entities
**********************************************************************
Sensitivity: general
|
Owner
|
Temporarily breaking main with this... |
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This was referenced Apr 30, 2026
This was referenced May 15, 2026
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR regarding dicussion 226:
#226
I've created the async overloads and UnitTests for it.