fix: use autocfg to detect rustc version#7
Merged
Conversation
remove targets, add toolchains, introduce cargo-hack
There was a problem hiding this comment.
Pull request overview
This PR implements automatic detection of Rust compiler version capabilities using the autocfg crate to conditionally use newer APIs in BorrowedBuf. The changes enable compatibility across different Rust nightly versions and stable by detecting whether BorrowedBuf::init_len() and related methods are available.
Key changes:
- Adds build-time feature detection for
borrowedbuf_initcapability using autocfg - Implements fallback code paths for older Rust versions that lack the newer
BorrowedBufAPI methods - Extends CI matrix to test against multiple Rust toolchain versions (nightly, specific nightly dates, and stable)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build.rs | Adds autocfg-based feature detection to probe for BorrowedBuf::init_len availability |
| Cargo.toml | Adds autocfg as a build dependency |
| src/lib.rs | Implements conditional compilation with separate code paths for new and old BorrowedBuf APIs, adding support for the maybe_uninit_fill feature when newer APIs aren't available |
| .github/workflows/ci.yml | Expands CI matrix to test multiple Rust versions and removes target-specific testing in favor of feature-powerset testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5b3cdea to
4853097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6