Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feat: add inputSearchSelect, add modal on textareaclick, small fixes
| export let dismissible = false; | ||
| export let type: 'info' | 'success' | 'warning' | 'error' = 'info'; | ||
| export let buttons: Buttons[] = []; | ||
| export let isAction = false; |
There was a problem hiding this comment.
Do we need this? I don't see where it's used. Also, it might not be clear to have two ways to control whether the action buttons show.
There was a problem hiding this comment.
We needed it in some initial design but now is not needed for this specific branch :)
| export let fullWidth = false; | ||
| export let autofocus = false; | ||
| export let interactiveOutput = false; | ||
| // Input value | ||
| export let stretch = true; |
There was a problem hiding this comment.
why were fullWidth and stretch added? I tried to compare the existing params with the new, but they look the same:
There was a problem hiding this comment.
fullWidth gives it the inline-size: 100% while stretch is flex:1
There was a problem hiding this comment.
@ArmanNik it's still a little confusing because, as someone who's just using the InputSelectSearch component, I'm not sure when/why I would use one or the other.
src/routes/console/project-[project]/settings/smtp/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/settings/smtp/+page.svelte
Outdated
Show resolved
Hide resolved
| addNotification({ | ||
| type: 'error', | ||
| message: error.message | ||
| }); |
There was a problem hiding this comment.
In loadSmsTemplate(), there's a try/catch that can catch an error if sdk.forConsole.projects.getSmsTemplate() fails, but that means loadSmsTemplate() would return null/undefined in those cases. That would be problematic, right?
There was a problem hiding this comment.
mmmmm in what way 🤔 we'd just show a notification right?
There was a problem hiding this comment.
@ArmanNik, wouldn't we add 2 error notifications then:
- when
sdk.forConsole.projects.getSmsTemplate()inloadSmsTemplate()throws an error - in here because template is
nullorundefinedwhen it's expected to not benullorundefined
Or wait...would loadSmsTemplate() just not resolve if there was an error 🧐
There was a problem hiding this comment.
I think it's still fine? I the function goes wrong the we show the error from the server and the locale doesn't change right?
| <Id value={'{{project}}'}>{'{{project}}'}</Id> | ||
| <Id value={'{{redirect}}'}>{'{{redirect}}'}</Id> | ||
| </EmailTemplate> | ||
| </div> |
There was a problem hiding this comment.
It seems all of these email templates are the same except for the type string passed to loadEmailTemplate(). If that's the case, can we simplify this in any way to reduce the duplicate code?
There was a problem hiding this comment.
If I remember correctly there were plans for them to be different from one another, hence why the repetition 🙃
src/routes/console/project-[project]/auth/templates/smsInvitationTemplate.svelte
Outdated
Show resolved
Hide resolved
package.json
Outdated
| "@analytics/google-analytics": "^1.0.5", | ||
| "@appwrite.io/console": "0.1.0", | ||
| "@appwrite.io/pink": "^0.0.6-rc.10", | ||
| "@appwrite.io/console": "npm:@aw-labs/sdk-console-smtp@^0.1.1", |
There was a problem hiding this comment.
We need to change this before merge, right?
There was a problem hiding this comment.
https://www.npmjs.com/package/christy-console
@lohanidamodar you can use version 0..4.0
| <CollapsibleItem | ||
| bind:open={smsLoginOpen} | ||
| on:click={(e) => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
Why is preventDefault needed?
There was a problem hiding this comment.
If I remember correctly, it's because otherwise the collapsible wouldn't open correctly
There was a problem hiding this comment.
a comment might be useful then
There was a problem hiding this comment.
a comment might be useful then
Agreed!
| const timeout = setTimeout(() => { | ||
| loading = true; | ||
| }, 1); |
There was a problem hiding this comment.
I think it's because Chen wanted to show the loader only if the request took more than 1 second
There was a problem hiding this comment.
Should be 1000 instead then, no?
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
See previous comments.
src/routes/console/project-[project]/auth/templates/smsLoginTemplate.svelte
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/templates/smsLoginTemplate.svelte
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/templates/smsLoginTemplate.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/templates/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/templates/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/templates/emailMagicUrlTemplate.svelte
Show resolved
Hide resolved
| class="link" | ||
| href="/#">here</a | ||
| >. | ||
| <!-- TODO: add link to docs --> |
There was a problem hiding this comment.
can we add the link ?
There was a problem hiding this comment.
I don't think we have it yet
5 participants
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
(Write your answer here.)