Skip to content

Feat: Add PgPool Support on Postgres#1261

Open
NotTabassum wants to merge 1 commit into
masterfrom
pgpool
Open

Feat: Add PgPool Support on Postgres#1261
NotTabassum wants to merge 1 commit into
masterfrom
pgpool

Conversation

@NotTabassum

Copy link
Copy Markdown

No description provided.

@CLAassistant

CLAassistant commented May 25, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NotTabassum
NotTabassum requested a review from Imtiaz246 May 25, 2026 06:55
@NotTabassum
NotTabassum force-pushed the pgpool branch 6 times, most recently from 762ed5d to b4e71c9 Compare June 1, 2026 03:57
@NotTabassum
NotTabassum force-pushed the pgpool branch 4 times, most recently from 0562a1a to df944a0 Compare June 2, 2026 04:10
@ArnobKumarSaha
ArnobKumarSaha marked this pull request as draft June 2, 2026 09:17
@NotTabassum
NotTabassum force-pushed the pgpool branch 10 times, most recently from 37f9cd4 to 077b5be Compare June 23, 2026 05:06
@NotTabassum
NotTabassum force-pushed the pgpool branch 4 times, most recently from 55e9e30 to 6ebf9bb Compare June 29, 2026 05:36
@NotTabassum
NotTabassum force-pushed the pgpool branch 2 times, most recently from fb6b5da to bd1b502 Compare July 15, 2026 10:17
@Imtiaz246
Imtiaz246 marked this pull request as ready for review July 17, 2026 09:15
@NotTabassum
NotTabassum force-pushed the pgpool branch 2 times, most recently from 77c5ffe to 468f2e1 Compare July 17, 2026 09:46
Comment thread charts/ace/templates/db/pgpool.yaml Outdated
Comment on lines +59 to +60
apiVersion: catalog.kubedb.com/v1alpha1
kind: PgpoolVersion

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the version object is needed here ?
ace hr depends on kubedb hr already I guess.

@ArnobKumarSaha ArnobKumarSaha Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pgpool is not enabled by default. Yes. the version object is needed here.
But then the problem is, the pgpool will not be ready

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be using feature gate to enable pgpool, will be updated.

Comment thread charts/ace/values.yaml Outdated
Comment on lines +299 to +301
num_init_children: "10"
max_pool: "40"
client_idle_limit: "180"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we calculate these configs ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tired with multiple connection limits. 400 worked, This num_init_children means parallel children process.

So max_pool can't be less than 15, so we keep that 15, and children 400/15 rest.

Updated the connection config.

num_init_children: "25"
max_pool: "15"

Signed-off-by: notTabassum <oyshee@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants