Skip to content

Avoid killing too many machines if one region is being shared between the remote primary and a satellite (snowflake/release-71.3)#9733

Merged
sfc-gh-akejriwal merged 1 commit into
apple:snowflake/release-71.3from
sfc-gh-abeamon:fix-shared-remote-region-kills-71.3
Mar 17, 2023
Merged

Avoid killing too many machines if one region is being shared between the remote primary and a satellite (snowflake/release-71.3)#9733
sfc-gh-akejriwal merged 1 commit into
apple:snowflake/release-71.3from
sfc-gh-abeamon:fix-shared-remote-region-kills-71.3

Conversation

@sfc-gh-abeamon

Copy link
Copy Markdown
Collaborator

Cherry pick #9727. This isn't strictly necessary at the moment since multi-region tests are disabled on this branch, but it's good to have if that ends up changing.

This modifies the simulated remote log policy to require more logs, preventing the simulator from killing machines that may be needed by other regions.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

…elliteTLogReplicationFactor and satelliteTLogUsableDcs. Update trace event with more info about the updated policy.
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 1202437
  • Duration 0:49:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 1202437
  • Duration 0:50:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 1202437
  • Duration 1:21:45
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@sfc-gh-akejriwal
sfc-gh-akejriwal merged commit f7c16cd into apple:snowflake/release-71.3 Mar 17, 2023
@sfc-gh-abeamon
sfc-gh-abeamon deleted the fix-shared-remote-region-kills-71.3 branch March 28, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants