Fix KeyRangeRef::isCovered() (#9675)#9697
Merged
sfc-gh-akejriwal merged 1 commit intoMar 15, 2023
Merged
Conversation
* fix KeyRangeRef::isCovered() * reproduce bug * more unit test added * fmt
sfc-gh-huliu
requested review from
sfc-gh-akejriwal,
sfc-gh-etschannen and
sfc-gh-jslocum
March 14, 2023 23:38
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
sfc-gh-etschannen
approved these changes
Mar 15, 2023
sfc-gh-akejriwal
left a comment
Collaborator
There was a problem hiding this comment.
Please add the main PR number in the description so that Github can link the two PRs.
Collaborator
Author
Done. thank you! |
sfc-gh-akejriwal
self-requested a review
March 15, 2023 19:15
sfc-gh-akejriwal
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed a bug in KeyRangeRef:isCovered(), which is used by hybrid restore.
cherry pick #9675
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)