Fix specialkeyspace workload [release-7.1]#9681
Merged
Merged
Conversation
This part of code has problems with GlobalConfig and is buggy.
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
xis19
reviewed
Mar 14, 2023
xis19
left a comment
Collaborator
There was a problem hiding this comment.
It seems that there are many more lines of code that main does not have in the release 7.1 branch. e.g. test ordered option keys, etc. Do we want to remove them too?
Collaborator
Author
My thinking is that as long as that code doesn't fail, we can keep them. I am not sure about that code. |
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
xis19
approved these changes
Mar 14, 2023
xis19
left a comment
Collaborator
There was a problem hiding this comment.
I am not quite sure about this change though...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part of code is known to have issues with GlobalConfig's initialization. The
mainbranch has refactored a lot, so this is not a cherrypick, but to fix the workload.Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)