Skip to content

The isHostname function could cause an unknown_error if regex parsing failed (snowflake/release-71.3)#9677

Merged
sfc-gh-akejriwal merged 1 commit into
apple:snowflake/release-71.3from
sfc-gh-abeamon:handle-hostname-parse-error-71.3
Mar 14, 2023
Merged

The isHostname function could cause an unknown_error if regex parsing failed (snowflake/release-71.3)#9677
sfc-gh-akejriwal merged 1 commit into
apple:snowflake/release-71.3from
sfc-gh-abeamon:handle-hostname-parse-error-71.3

Conversation

@sfc-gh-abeamon

Copy link
Copy Markdown
Collaborator

This is a cherry pick of #9676

This catches the std::exception, logs a trace event, and converts it to an FDB exception

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 23f8f73
  • Duration 0:28:27
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 23f8f73
  • Duration 1:17:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 23f8f73
  • Duration 1:23:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 23f8f73
  • Duration 3:00:27
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@sfc-gh-clin sfc-gh-clin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-akejriwal
sfc-gh-akejriwal merged commit fb6b285 into apple:snowflake/release-71.3 Mar 14, 2023
@sfc-gh-abeamon
sfc-gh-abeamon deleted the handle-hostname-parse-error-71.3 branch March 28, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants