[EaR]: Update KMS request/response to embedd version details by sfc-gh-ahusain · Pull Request #9135 · apple/foundationdb

sfc-gh-ahusain · 2023-01-13T05:59:10Z

Description

Patch embedd 'version_tag' detail to KMS JSON request/response payload, this features enables future expansion as well as enables the path to support multiple versions simulatanesouly if needed

Testing

RESTKmsConnectorUnit.toml updated as per new code
devRunCorrectness - 100K

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2023-01-13T06:19:35Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: ecd60c4
Duration 0:20:14
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-01-13T06:20:17Z

Doxense CI Report for Windows 10

Commit ID: ecd60c4
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-01-13T06:45:57Z

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

Commit ID: ecd60c4
Duration 0:46:33
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T06:52:03Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: ecd60c4
Duration 0:52:43
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T06:58:30Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: ecd60c4
Duration 0:59:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T07:17:26Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: ecd60c4
Duration 1:18:08
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T07:19:32Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: ecd60c4
Duration 1:20:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

fdb-windows-ci · 2023-01-13T18:49:59Z

Doxense CI Report for Windows 10

Commit ID: 7c46f30
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-01-13T18:57:16Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 7c46f30
Duration 0:19:30
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T19:21:40Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 7c46f30
Duration 0:42:57
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T19:28:52Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 7c46f30
Duration 0:51:06
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T20:02:12Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 7c46f30
Duration 1:24:20
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

fdb-windows-ci · 2023-01-13T20:30:44Z

Doxense CI Report for Windows 10

Commit ID: d68b340
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-01-13T20:38:14Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: d68b340
Duration 0:17:48
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T20:52:50Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: d68b340
Duration 0:32:25
Result: ❌ FAILED
Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/foundationdb-kubernetes-sidecar:${FDB_VERSION}-${COMMIT_SHA}-1 --file Dockerfile --target foundationdb-kubernetes-sidecar .. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-01-13T21:06:21Z

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

Commit ID: d68b340
Duration 0:45:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T21:12:27Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: d68b340
Duration 0:52:01
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T21:12:54Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: d68b340
Duration 0:52:28
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T21:16:03Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: d68b340
Duration 0:55:38
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T22:10:06Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: c2c0bfb
Duration 0:20:14
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T22:42:27Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: c2c0bfb
Duration 0:52:39
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T22:45:18Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: c2c0bfb
Duration 0:55:28
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-01-13T22:52:57Z

Doxense CI Report for Windows 10

Commit ID: c2c0bfb
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-01-13T22:53:18Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: c2c0bfb
Duration 1:03:27
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-13T23:17:00Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: c2c0bfb
Duration 1:27:13
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

Description Patch embedd 'version_tag' detail to KMS JSON request/response payload, this features enables future expansion as well as enables the path to support multiple versions simulatanesouly if needed Testing RESTKmsConnectorUnit.toml updated as per new code devRunCorrectness - 100K

Description diff-1 : Address review comments Patch embedd 'version_tag' detail to KMS JSON request/response payload, this features enables future expansion as well as enables the path to support multiple versions simulatanesouly if needed Testing RESTKmsConnectorUnit.toml updated as per new code devRunCorrectness - 100K

fdb-windows-ci · 2023-01-14T03:49:35Z

Doxense CI Report for Windows 10

Commit ID: 0a78363
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-01-14T03:56:12Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 0a78363
Duration 0:19:21
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-14T04:21:02Z

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

Commit ID: 0a78363
Duration 0:43:17
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-14T04:28:49Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: 0a78363
Duration 0:51:54
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-14T04:39:35Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 0a78363
Duration 1:02:43
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-14T04:49:12Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 0a78363
Duration 1:12:21
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-01-14T04:59:50Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 0a78363
Duration 1:22:01
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

* main: (33 commits) Change PTreeImpl::insert to overwrite existing entries (apple#9138) Add correct test for blob restore with large workload [EaR]: Update KMS request/response to embedd version details (apple#9135) client config tests: Improve readability of ClientConfigTest interface get_client_status: fix formatting in comments get_client_report: commenting DatabaseState::getClientStatus client_status_report: Change variable names get_client_status: a comment giving a more precise description get_client_status: document the schema of the returned json client_status_report: report cluster id from the DatabaseContext only get_client_status: remove redundant call to getRecentClosedPeers client_config_tester: Add a comment describing its contract client_config_tester: Adding missing break in switch case Validate Storage part II (apple#8471) add some rocksdb compile options that can be passed in at build time (apple#9141) Decrease the number of HCA test rounds to decrease the test time tenant entry was removed, changed to fixme (apple#9132) set watchTenantCheck within deleteTenant Fix tenant delete loop Clean up log messages ...

sfc-gh-ahusain requested review from sfc-gh-jslocum, sfc-gh-nwijetunga and sfc-gh-yiwu January 13, 2023 05:59

sfc-gh-nwijetunga reviewed Jan 13, 2023

View reviewed changes

Comment thread fdbserver/RESTKmsConnector.actor.cpp

sfc-gh-ahusain requested a review from sfc-gh-nwijetunga January 13, 2023 18:37

sfc-gh-nwijetunga reviewed Jan 13, 2023

View reviewed changes

Comment thread fdbserver/RESTKmsConnector.actor.cpp Outdated

sfc-gh-nwijetunga previously approved these changes Jan 13, 2023

View reviewed changes

sfc-gh-jslocum previously approved these changes Jan 13, 2023

View reviewed changes

sfc-gh-ahusain dismissed stale reviews from sfc-gh-jslocum and sfc-gh-nwijetunga via d68b340 January 13, 2023 20:20

sfc-gh-ahusain force-pushed the ahusain-kms-api-updates branch from d68b340 to c2c0bfb Compare January 13, 2023 21:49

sfc-gh-ahusain added 3 commits January 13, 2023 19:36

sfc-gh-ahusain force-pushed the ahusain-kms-api-updates branch from c2c0bfb to 0a78363 Compare January 14, 2023 03:36

sfc-gh-ahusain requested review from sfc-gh-jslocum and sfc-gh-nwijetunga January 16, 2023 19:50

sfc-gh-nwijetunga approved these changes Jan 16, 2023

View reviewed changes

sfc-gh-ahusain merged commit 3f2404c into apple:main Jan 16, 2023

Uh oh!

Conversation

sfc-gh-ahusain commented Jan 13, 2023

Code-Reviewer Section

For Release-Branches

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Jan 13, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-macos on macOS Monterey 12.x

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

Uh oh!

fdb-windows-ci commented Jan 13, 2023

Doxense CI Report for Windows 10

Uh oh!

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Jan 13, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-macos on macOS Monterey 12.x

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-macos on macOS Monterey 12.x

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Jan 13, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jan 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!