Skip to content

Moving rocksdb read iterator destruction from commit path to actor.#8970

Merged
neethuhaneesha merged 1 commit into
apple:mainfrom
neethuhaneesha:readIterDestr
Dec 12, 2022
Merged

Moving rocksdb read iterator destruction from commit path to actor.#8970
neethuhaneesha merged 1 commit into
apple:mainfrom
neethuhaneesha:readIterDestr

Conversation

@neethuhaneesha

@neethuhaneesha neethuhaneesha commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Moving rocksdb read iterator destruction from commit path to actor.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci

foundationdb-ci commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 4428433
  • Duration 0:30:27
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Dec 3, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 1c4ef30
  • Duration 0:23:09
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Dec 3, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

jzhou77
jzhou77 reviewed Dec 5, 2022
View reviewed changes
Comment thread fdbserver/KeyValueStoreRocksDB.actor.cpp
neethuhaneesha
neethuhaneesha commented Dec 5, 2022
View reviewed changes
Comment thread fdbserver/KeyValueStoreRocksDB.actor.cpp Outdated
@foundationdb-ci

foundationdb-ci commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f4743b2
  • Duration 1:01:06
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Dec 5, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@fdb-windows-ci

fdb-windows-ci commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 24aff4c
  • Duration 0:40:44
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Monterey 12.x

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 6e460d9
  • Duration 0:47:56
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Monterey 12.x

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 6e460d9
  • Duration 0:53:38
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci

fdb-windows-ci commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci

foundationdb-ci commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Dec 12, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@neethuhaneesha neethuhaneesha mentioned this pull request Dec 12, 2022
Merged
5 tasks
@foundationdb-ci

foundationdb-ci commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@neethuhaneesha
neethuhaneesha merged commit 3a4d79c into apple:main Dec 12, 2022
sfc-gh-nwijetunga added a commit to sfc-gh-nwijetunga/foundationdb that referenced this pull request Dec 12, 2022
@sfc-gh-nwijetunga
Merge branch 'main' into nim/cp-uses-db-config
c305a41 
* main:
  Moving rocksdb read iterator destruction from commit path to actor. (apple#8970)
  Nit fix
  apply format in fdbclient/FDBTypes.cpp
  Update physical shard tracking document.
  Fix issue with KeyRangeRef original data gone.
  Add code document.
  During initialization, keyRangePhysicalShardIDMap may not contain full range. Adjust assertion in checkKeyRangePhysicalShardMapping
  Create per physical shard tracking data stucture. Not populate yet
  Do not compress debug sections in release builds (apple#9005)
  Fix assertion failure from changeFeedTSSValidator()
  metrics: Fix windows build
  Fix feed metadata reset (apple#8751)
  MultiVersionTransaction: Improve Comments
  MultiVersionTransaction: Add comments
  MultiverstionTransaction: Remove redundant setOption calls
  The pair name will only match when we are deleting the source tenant entry
  Add an assert in deleteTenantFromManagementCluster that the tenant's pair name matches the locally stored pair name
  DeleteTenantImpl::markTenantInRemovingState needs to record the pair name even if the tenant is already in a removing state (it could be a pair in the process of being removed). Use better asserts in tenant consistency.
@neethuhaneesha
neethuhaneesha deleted the readIterDestr branch December 12, 2022 23:18
sfc-gh-nwijetunga added a commit to sfc-gh-nwijetunga/foundationdb that referenced this pull request Dec 13, 2022
@sfc-gh-nwijetunga
Merge branch 'main' into nim/fix-encrypted-backup-workload
08b2123 
* main:
  Moving rocksdb read iterator destruction from commit path to actor. (apple#8970)
  Nit fix
  apply format in fdbclient/FDBTypes.cpp
  Update physical shard tracking document.
  Fix issue with KeyRangeRef original data gone.
  Add code document.
  During initialization, keyRangePhysicalShardIDMap may not contain full range. Adjust assertion in checkKeyRangePhysicalShardMapping
  Create per physical shard tracking data stucture. Not populate yet
  Do not compress debug sections in release builds (apple#9005)
  Fix assertion failure from changeFeedTSSValidator()
  metrics: Fix windows build
  Fix feed metadata reset (apple#8751)
  MultiVersionTransaction: Improve Comments
  MultiVersionTransaction: Add comments
  MultiverstionTransaction: Remove redundant setOption calls
  The pair name will only match when we are deleting the source tenant entry
  Add an assert in deleteTenantFromManagementCluster that the tenant's pair name matches the locally stored pair name
  DeleteTenantImpl::markTenantInRemovingState needs to record the pair name even if the tenant is already in a removing state (it could be a pair in the process of being removed). Use better asserts in tenant consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liquid-helium liquid-helium Awaiting requested review from liquid-helium
@jzhou77 jzhou77 Awaiting requested review from jzhou77
1 more reviewer
@xy-54321 xy-54321 xy-54321 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@neethuhaneesha @foundationdb-ci @fdb-windows-ci @jzhou77 @liquid-helium @xy-54321