Skip to content

Rocksdb suggest compact range checks#8861

Merged
jzhou77 merged 1 commit into
apple:release-7.2from
neethuhaneesha:suggest-compacts-7.2
Nov 18, 2022
Merged

Rocksdb suggest compact range checks#8861
jzhou77 merged 1 commit into
apple:release-7.2from
neethuhaneesha:suggest-compacts-7.2

Conversation

@neethuhaneesha

Copy link
Copy Markdown
Contributor

Rocksdb suggest compact range checks
cherry-pick of #8848

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

liquid-helium
liquid-helium previously approved these changes Nov 17, 2022
jzhou77
jzhou77 previously approved these changes Nov 17, 2022
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

@jzhou77
jzhou77 dismissed stale reviews from liquid-helium and themself via 4a096ce November 18, 2022 01:56
@jzhou77
jzhou77 merged commit 1803b8a into apple:release-7.2 Nov 18, 2022
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@neethuhaneesha
neethuhaneesha deleted the suggest-compacts-7.2 branch November 18, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants