add bytelimit for prefetch with better granularity by flowguru · Pull Request #8756 · apple/foundationdb

flowguru · 2022-11-09T01:45:26Z

This change adds bytelimit for prefetch API inside fdbserver, in order to do that, a better granularity is provided when fetching indexes and record.

Instead of fetching index once for each prefetch call, now there might be multiple index fetches.

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2022-11-09T02:02:11Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 1425d5b
Duration 0:16:36
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T02:12:45Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 1425d5b
Duration 0:27:11
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T02:12:47Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 1425d5b
Duration 0:27:08
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T02:28:23Z

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

Commit ID: 1425d5b
Duration 0:42:49
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T02:30:52Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: 1425d5b
Duration 0:45:14
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

flowguru · 2022-11-09T03:04:13Z

seems there are some testing issue, will take a look tomorrow

trace.0.0.0.0.0.1667954641.8ThUSC.0.1.xml:<Event Severity="40" ErrorKind="BugDetected" Time="82.273948" DateTime="2022-11-09T00:44:02Z" Type="InternalError" Machine="3.4.3.2:1" ID="0000000000000000" Error="internal_error" ErrorDescription="An internal error occurred" ErrorCode="4100" FailedAssertion="resultSize % SERVER_KNOBS-&gt;PREFETCH_INDEX_PAGE_SIZE == 0" File="/root/src/foundationdb/fdbserver/workloads/GetMappedRange.actor.cpp" Line="325" ThreadID="209490852615957828" Backtrace="addr2line -e fdbserver.debug -p -C -f -i 0x4420dbc 0x441f9f0 0x441fdee 0x43525fa 0x2d1c085 0x2d1ca05 0x2d1ac68 0x2d1bc95 0x3869838 0x39b697a 0x39ba04c 0x38fa828 0x39b2f88 0x39b311e 0x395b3e8 0xd8b158 0x4208c47 0x420930b 0x43062c8 0xc94a72 0x7f75a1463555" LogGroup="default" Roles="TS" />
trace.0.0.0.0.0.1667954641.8ThUSC.0.1.xml:<Event Severity="40" ErrorKind="Unset" Time="82.273948" DateTime="2022-11-09T00:44:02Z" Type="SystemError" Machine="3.4.3.2:1" ID="0000000000000000" Error="internal_error" ErrorDescription="An internal error occurred" ErrorCode="4100" ThreadID="209490852615957828" Backtrace="addr2line -e fdbserver.debug -p -C -f -i 0x4420dbc 0x441f9f0 0x441fdee 0x43520b8 0x435260c 0x2d1c085 0x2d1ca05 0x2d1ac68 0x2d1bc95 0x3869838 0x39b697a 0x39ba04c 0x38fa828 0x39b2f88 0x39b311e 0x395b3e8 0xd8b158 0x4208c47 0x420930b 0x43062c8 0xc94a72 0x7f75a1463555" LogGroup="default" Roles="TS" />
trace.0.0.0.0.0.1667954641.8ThUSC.0.1.xml:<Event Severity="40" ErrorKind="Unset" Time="82.273948" DateTime="2022-11-09T00:44:02Z" Type="TestFailure" Machine="3.4.3.2:1" ID="d74d63c0492fcee5" Error="internal_error" ErrorDescription="An internal error occurred" ErrorCode="4100" Reason="Error starting workload" Workload="GetMappedRange" ThreadID="209490852615957828" Backtrace="addr2line -e fdbserver.debug -p -C -f -i 0x4420dbc 0x441f9f0 0x441fdee 0x26e588c 0x26e59d7 0xd31569 0xdd3b19 0xd31569 0xd31569 0x26ba939 0xd31569 0x2d14de1 0xd31569 0x2d1ca8d 0x2d1ac68 0x2d1bc95 0x3869838 0x39b697a 0x39ba04c 0x38fa828 0x39b2f88 0x39b311e 0x395b3e8 0xd8b158 0x4208c47 0x420930b 0x43062c8 0xc94a72 0x7f75a1463555" LogGroup="default" Roles="TS" />
trace.0.0.0.0.0.1667954641.8ThUSC.0.1.xml:<Event Severity="40" ErrorKind="Unset" Time="82.275760" DateTime="2022-11-09T00:44:02Z" Type="StartFailedForWorkloadGetMappedRange" Machine="0.0.0.0:0" ID="0000000000000000" Error="operation_failed" ErrorDescription="Operation failed" ErrorCode="1000" ThreadID="209490852615957828" Backtrace="addr2line -e fdbserver.debug -p -C -f -i 0x4420dbc 0x441f9f0 0x441fdee 0x2725f79 0x26f53f4 0x26f5560 0xe5a498 0x10bc508 0x110c309 0x110c97a 0xd31569 0xdd63dd 0xdd66db 0xd31569 0xd3ea0c 0x4208c47 0x420930b 0x43062c8 0xc94a72 0x7f75a1463555" LogGroup="default" />

foundationdb-ci · 2022-11-09T03:12:00Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f4c85eb
Duration 0:16:56
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T03:19:17Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f4c85eb
Duration 0:24:17
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T03:19:44Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 907f4f5
Duration 0:17:05
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T03:23:15Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f4c85eb
Duration 0:28:15
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T03:27:03Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 907f4f5
Duration 0:24:23
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T03:28:47Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 907f4f5
Duration 0:26:08
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-09T03:41:02Z

Doxense CI Report for Windows 10

Commit ID: f4c85eb
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-11-09T03:43:56Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 1425d5b
Duration 1:58:17
Result: ❌ FAILED
Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T04:52:22Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f4c85eb
Duration 1:57:20
Result: ❌ FAILED
Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T05:01:54Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 907f4f5
Duration 1:59:12
Result: ❌ FAILED
Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-09T06:37:14Z

Doxense CI Report for Windows 10

Commit ID: 907f4f5
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

This change adds bytelimit for prefetch API inside fdbserver, in order to do that, a better granularity is provided when fetching indexes and record. Instead of fetching index once for each prefetch call, now there might be multiple index fetches.

foundationdb-ci · 2022-11-09T08:25:54Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: d0276ea
Duration 0:15:49
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:31:07Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 66c7210
Duration 0:10:23
Result: ❌ FAILED
Error: reference not found for primary source and source version 66c7210ec95178c6de43c55b143d0680f1af73cc
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:31:07Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 66c7210
Duration 0:10:19
Result: ❌ FAILED
Error: reference not found for primary source and source version 66c7210ec95178c6de43c55b143d0680f1af73cc
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-09T08:31:56Z

Doxense CI Report for Windows 10

Commit ID: 66c7210
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-11-09T08:32:04Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: d0276ea
Duration 0:21:58
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:32:04Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: 66c7210
Duration 0:11:17
Result: ❌ FAILED
Error: reference not found for primary source and source version 66c7210ec95178c6de43c55b143d0680f1af73cc
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:37:59Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: d0276ea
Duration 0:27:50
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:41:13Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: b729562
Duration 0:16:40
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:48:19Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: b729562
Duration 0:23:46
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:51:18Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 66c7210
Duration 0:30:29
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:51:38Z

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

Commit ID: d0276ea
Duration 0:41:32
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:53:17Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: b729562
Duration 0:28:46
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T08:54:18Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: b729562
Duration 0:29:48
Result: ❌ FAILED
Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/ycsb:${FDB_VERSION}-${COMMIT_SHA} --file Dockerfile --target ycsb .. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-09T08:54:33Z

Doxense CI Report for Windows 10

Commit ID: b729562
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-11-09T10:07:28Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: d0276ea
Duration 1:57:22
Result: ❌ FAILED
Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T10:18:34Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 66c7210
Duration 1:57:45
Result: ❌ FAILED
Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

alecgrieser

LGTM, though I'm not an expert on this code. To summarize, the major changes are:

During the scan of the primary range, a new "page size" parameter is added which breaks up the scan into multiple fetches
The mapping of keys to other keys now checks the remaining bytes and stops executing batches of secondary fetches if the byte limit is exceeded. The batch size default is also decreased from 50 to 10.

Overall, this should result in getting requests to be closer to the configured byte limit, as the amount of potential overrun is limited to one page's worth of the primary range (from step 1) plus one batch's worth of secondary fetches (from step 2)

alecgrieser · 2022-11-09T11:59:58Z

+			// fill index KV for open boundary
+			if (firstBatch && i + offset == 0) {
+				result->data[0].key = input.data[0].key;
+				result->data[0].value = input.data[0].value;
+			}


I'm not sure I understand what this if block is trying to do. Why does result->data[0] need to be filled in in this case?

we provide the index key for both the begin and the end of the range, so that client can use them as continuations -- I think it is because we might scan forward/backward, so we add both. Here it is the beginning.

alecgrieser · 2022-11-09T12:03:24Z

-				throw;
+				// these fields always return as the value of the last batch result
+				result.version = getKeyValuesReply.version;
+				result.cached = getKeyValuesReply.cached;


What does this cached value represent? Is it correct to always set it to the last one?

we can remove it, because I do not think it is used anywhere, @ohadzeliger can you please verify that RL has not been using this field?

Do you mean cached field?

oh i mean the value of this field might not used in prefetch code path, not deleting this field from code

cahced is not exposed through the Java bindings, we don't see it.

ohadzeliger · 2022-11-09T15:56:56Z

@@ -4602,52 +4602,59 @@ ACTOR Future<Void> mapSubquery(StorageServer* data,
                               Arena* pArena,
                               int matchIndex,
                               bool isRangeQuery,


Does removing isBoundary make the protocol level change?

two things:

removing the field in java/c bindings might cause issues, and we should be careful about that.

but this value is not being used anyway, and this field here is fdbserver internal, so my plan is to not setting it until we remove it. I can add a comments like "to be deleted" in that field

ohadzeliger · 2022-11-09T15:57:33Z

+	init( STRICTLY_ENFORCE_BYTE_LIMIT, 							false); // If set to false, prefetch response might exceeed byteLimit as records are fetched in batch
+	// tentatively use the limit of secondary queries so that 1 primary query serves one batch
+	// we can increase this to gain better performance after proper benchmarking
+	init( PREFETCH_INDEX_PAGE_SIZE,                               20 ); if ( randomize && BUGGIFY ) PREFETCH_INDEX_PAGE_SIZE = deterministicRandom()->randomInt(50, 100);


PREFETCH_INDEX_PAGE_SIZE cannot be controlled by the client API, right?

right, that needs a protocol change, and I am not sure if want to expose that anyways.

ohadzeliger · 2022-11-09T16:11:03Z

 		Key endTuple = Tuple::makeTuple(prefix, INDEX, indexKey(endId)).getDataAsStandalone();
 		state KeySelector endSelector = KeySelector(firstGreaterOrEqual(endTuple));
 		state int limit = 100;
+		state int byteLimit = deterministicRandom()->randomInt(1, 9) * 10000;


What is the purpose of this (why is it random)?

because when byteLimit is large, we want to test up to(but not exceeding) limit rows can be returned, when it is small, we want to test fewer than limit rows can be returned. So both cases need to be tested.

fdb-windows-ci · 2022-11-10T00:10:40Z

Doxense CI Report for Windows 10

Commit ID: e52043f
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-11-10T00:10:54Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 81c9adc
Duration 0:22:58
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-10T00:13:01Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 81c9adc
Duration 0:25:03
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-10T00:16:46Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 81c9adc
Duration 0:28:47
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-10T00:18:02Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: e52043f
Duration 0:23:15
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-10T00:19:15Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: e52043f
Duration 0:24:27
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-10T00:23:59Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: e52043f
Duration 0:29:13
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-10T01:45:53Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 81c9adc
Duration 1:58:00
Result: ❌ FAILED
Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-10T01:55:02Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: e52043f
Duration 2:00:15
Result: ❌ FAILED
Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

flowguru · 2022-11-10T06:19:15Z

check #8768 instead

flowguru requested review from alecgrieser and jzhou77 November 9, 2022 01:45

flowguru force-pushed the b2 branch from f4c85eb to 907f4f5 Compare November 9, 2022 03:02

flowguru force-pushed the b2 branch 2 times, most recently from d0276ea to 66c7210 Compare November 9, 2022 08:20

flowguru force-pushed the b2 branch from 66c7210 to b729562 Compare November 9, 2022 08:24

alecgrieser previously approved these changes Nov 9, 2022

View reviewed changes

ohadzeliger reviewed Nov 9, 2022

View reviewed changes

Fix result.more, first entry of the batch and formats

81c9adc

flowguru dismissed alecgrieser’s stale review via 81c9adc November 9, 2022 23:47

add randomness in Knob

e52043f

flowguru closed this Nov 10, 2022

Uh oh!

Conversation

flowguru commented Nov 9, 2022

Code-Reviewer Section

For Release-Branches

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

Uh oh!

flowguru commented Nov 9, 2022

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Nov 9, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Nov 9, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Nov 9, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!