Cherry pick PR 8630 to release 7.1 by dlambrig · Pull Request #8740 · apple/foundationdb

dlambrig · 2022-11-08T16:54:16Z

Cherry pick PR 8630 to release 7.1 (Apple)

The 7.1 release does not have tests in test/apitester. The changes to bindings/c/CMakeLists.txt are not included.

Needed to take flame graphs on client fdb code.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2022-11-08T17:15:14Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 339543a
Duration 0:20:46
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-08T17:20:44Z

Doxense CI Report for Windows 10

Commit ID: 339543a
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

jzhou77

This introduces a new network option, which means fdb client library needs to be updated for customers to use this feature.

foundationdb-ci · 2022-11-08T17:30:36Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 339543a
Duration 0:36:09
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-08T18:38:54Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 339543a
Duration 1:44:28
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-08T22:37:59Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 74bd75c
Duration 0:21:01
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-08T22:52:20Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 74bd75c
Duration 0:35:17
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-08T23:24:37Z

Doxense CI Report for Windows 10

Commit ID: 74bd75c
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-11-08T23:59:13Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 74bd75c
Duration 1:42:13
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

jzhou77 · 2022-11-09T00:07:27Z


 <Options>
  <Scope name="NetworkOption">
+    <Option name="retain_client_library_copies" code="67"


This causes update_bindings_go_src_fdb_generated_go test to fail. You'll need to update bindings/go/src/fdb/generated.go file.

update_bindings_go_src_fdb_generated_go compares a generated go file with the existing one, and fails on mismatch ( as far as I can tell.)

foundationdb-ci · 2022-11-09T02:45:37Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 1439943
Duration 0:22:37
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T02:59:31Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 1439943
Duration 0:36:29
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T04:07:22Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 1439943
Duration 1:44:24
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-09T05:39:44Z

Doxense CI Report for Windows 10

Commit ID: 1439943
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

sfc-gh-vgasiunas · 2022-11-09T09:42:03Z

    endif()
  endif()
-  set(USE_AVX OFF CACHE BOOL "Enable AVX instructions")
+  set(USE_AVX ON CACHE BOOL "Enable AVX instructions")


That does not seem related to the cherry-pick. Is it necessary?

Yes. This should be reverted.

jzhou77 · 2022-11-09T16:43:20Z

Because of a CI change, you need to cherrypick #8761 as well.

foundationdb-ci · 2022-11-09T17:58:10Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f58d449
Duration 0:21:28
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T18:05:21Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 4f3eaa0
Duration 0:23:13
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T18:55:02Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: e58d388
Duration 0:21:12
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:02:51Z

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

Commit ID: e58d388
Duration 0:29:03
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:08:17Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: e58d388
Duration 0:34:27
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:11:56Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: e58d388
Duration 0:38:07
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:27:53Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f58d449
Duration 1:51:07
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:30:23Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f58d449
Duration 1:48:24
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:30:45Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 4f3eaa0
Duration 1:48:36
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:46:26Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: cf8b9fa
Duration 0:22:01
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:53:52Z

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

Commit ID: cf8b9fa
Duration 0:29:28
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T19:59:52Z

Result of foundationdb-pr-macos on macOS Monterey 12.x

Commit ID: cf8b9fa
Duration 0:35:29
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-09T20:00:23Z

Doxense CI Report for Windows 10

Commit ID: 91f452e
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-11-09T20:01:28Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: cf8b9fa
Duration 0:37:05
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T20:05:47Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 91f452e
Duration 0:21:25
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T20:21:48Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 91f452e
Duration 0:37:24
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T20:22:28Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: e58d388
Duration 1:48:42
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

jzhou77 · 2022-11-09T20:37:23Z

 	return buf
 }

+// Retain temporary external client library copies that are created for enabling multi-threading.


It doesn't look like #8761 was cherrypicked.

yes, I was using the old Go version in okteto. It will be in the next revision.

foundationdb-ci · 2022-11-09T21:10:50Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: cf8b9fa
Duration 1:46:29
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

fdb-windows-ci · 2022-11-09T21:27:49Z

Doxense CI Report for Windows 10

Commit ID: 3b52fc4
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-11-09T21:30:11Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 91f452e
Duration 1:45:44
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

jzhou77

Thanks!

foundationdb-ci · 2022-11-09T22:06:21Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 3b52fc4
Duration 0:46:55
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T22:17:02Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 3b52fc4
Duration 0:57:35
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci · 2022-11-09T23:04:02Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 3b52fc4
Duration 1:44:34
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)
Build Artifact (available for 30 days)

foundationdb-ci and others added 2 commits November 7, 2022 23:12

enable AVX and update version for 7.1.24 release

1405bd6

Cherry pick 8630

339543a

dlambrig requested a review from jzhou77 November 8, 2022 16:58

jzhou77 previously approved these changes Nov 8, 2022

View reviewed changes

foundationdb-ci force-pushed the release-7.1 branch from 3ed8ff0 to 6cb7ac4 Compare November 8, 2022 20:35

dlambrig marked this pull request as ready for review November 8, 2022 22:14

dlambrig requested a review from sfc-gh-vgasiunas November 8, 2022 22:15

jzhou77 reviewed Nov 9, 2022

View reviewed changes

add generated.go

1439943

dlambrig dismissed jzhou77’s stale review via 1439943 November 9, 2022 02:22

dlambrig force-pushed the r71 branch from 74bd75c to 1439943 Compare November 9, 2022 02:22

sfc-gh-vgasiunas reviewed Nov 9, 2022

View reviewed changes

dlambrig requested a review from jzhou77 November 9, 2022 11:52

dlambrig closed this Nov 9, 2022

dlambrig reopened this Nov 9, 2022

Update generated.go

91f452e

jzhou77 requested changes Nov 9, 2022

View reviewed changes

Update generated.go with 8761

3b52fc4

jzhou77 approved these changes Nov 9, 2022

View reviewed changes

jzhou77 requested a review from halfprice November 9, 2022 21:49

halfprice approved these changes Nov 9, 2022

View reviewed changes

jzhou77 merged commit 288e922 into release-7.1 Nov 9, 2022

jzhou77 mentioned this pull request Nov 9, 2022

[release-7.1] Add SS read range bytes metrics. (#8697) #8724

Merged

5 tasks

dlambrig deleted the r71 branch November 9, 2022 23:49

Uh oh!

Conversation

dlambrig commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code-Reviewer Section

For Release-Branches

Uh oh!

foundationdb-ci commented Nov 8, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Nov 8, 2022

Doxense CI Report for Windows 10

Uh oh!

jzhou77 left a comment

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented Nov 8, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 8, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 8, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 8, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Nov 8, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Nov 8, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

jzhou77 Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

dlambrig Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Nov 9, 2022

Doxense CI Report for Windows 10

Uh oh!

sfc-gh-vgasiunas Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

jzhou77 Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

dlambrig Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

jzhou77 commented Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

Uh oh!

foundationdb-ci commented Nov 9, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

Uh oh!

dlambrig commented Nov 8, 2022 •

edited

Loading

dlambrig Nov 9, 2022 •

edited

Loading

jzhou77 commented Nov 9, 2022 •

edited

Loading

dlambrig Nov 9, 2022 •

edited

Loading