Skip to content

Rocksdb stats level knob.#8711

Merged
neethuhaneesha merged 1 commit into
apple:mainfrom
neethuhaneesha:metrics
Nov 8, 2022
Merged

Rocksdb stats level knob.#8711
neethuhaneesha merged 1 commit into
apple:mainfrom
neethuhaneesha:metrics

Conversation

@neethuhaneesha

@neethuhaneesha neethuhaneesha commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Rocksdb stats level knob.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Monterey 12.x

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 25558a6
  • Duration 0:55:42
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci

fdb-windows-ci commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 25558a6
  • Duration 1:57:48
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@neethuhaneesha neethuhaneesha mentioned this pull request Nov 6, 2022
Merged
5 tasks
@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 66aeac9
  • Duration 1:57:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

liquid-helium
liquid-helium reviewed Nov 7, 2022
View reviewed changes
Comment thread fdbserver/KeyValueStoreRocksDB.actor.cpp
statistics->histogramData(histogram, &histogram_data);
e.detail(format("%s%d", name, "P95"), histogram_data.percentile95);
e.detail(format("%s%d", name, "P99"), histogram_data.percentile99);
if (SERVER_KNOBS->ROCKSDB_STATS_LEVEL > rocksdb::kExceptHistogramOrTimers) {

@liquid-helium liquid-helium Nov 7, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here about the meaning of this if condition?

@neethuhaneesha neethuhaneesha Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

xy-54321
xy-54321 previously approved these changes Nov 7, 2022
View reviewed changes
@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: bd7a45e
  • Duration 0:34:12
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Monterey 12.x

liquid-helium
liquid-helium previously approved these changes Nov 7, 2022
View reviewed changes
@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: bd7a45e
  • Duration 1:57:52
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@neethuhaneesha
neethuhaneesha dismissed stale reviews from liquid-helium and xy-54321 via 237814f November 7, 2022 21:35
@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 237814f
  • Duration 0:29:23
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@fdb-windows-ci

fdb-windows-ci commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 237814f
  • Duration 2:00:24
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci

foundationdb-ci commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 80f5a09
  • Duration 2:00:01
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci

fdb-windows-ci commented Nov 8, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@neethuhaneesha
neethuhaneesha merged commit ca33fe1 into apple:main Nov 8, 2022
sfc-gh-nwijetunga added a commit to sfc-gh-nwijetunga/foundationdb that referenced this pull request Nov 9, 2022
@sfc-gh-nwijetunga
Merge branch 'main' into nim/fix-bulk-load
7624d3f 
* main:
  Blob single part upload (apple#8703)
  Addressed review comments
  Extend Transaction Window during Restore in Simulation (apple#8729)
  Increase default GLOBAL_TAG_THROTTLING_FOLDING_TIME
  EAR: fix Redwood encryption system key space prefix (apple#8698)
  Rocksdb stats level knob. (apple#8711)
  Add CLI Argument to Override Snapshot Backup Encryption (apple#8661)
  Disable taking the ss read lock due to a 5% read perf regression in 100% cached read, CPU-bound scenario.
  Fix go usage in mock_kms cmake commands.
  make trackExcludedServers PRIORITY_SYSTEM_IMMEDIATE
@neethuhaneesha
neethuhaneesha deleted the metrics branch November 16, 2022 21:01
@neethuhaneesha neethuhaneesha mentioned this pull request Nov 16, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@xy-54321 xy-54321 xy-54321 approved these changes
@liquid-helium liquid-helium liquid-helium left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@liquid-helium liquid-helium

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neethuhaneesha @foundationdb-ci @fdb-windows-ci @liquid-helium @xy-54321