Skip to content

moving fdbblob in sim folder for simulations - #8701

Merged
sfc-gh-jslocum merged 1 commit into
apple:mainfrom
sfc-gh-jslocum:bg_unseed
Nov 4, 2022
Merged

moving fdbblob in sim folder for simulations#8701
sfc-gh-jslocum merged 1 commit into
apple:mainfrom
sfc-gh-jslocum:bg_unseed

Conversation

@sfc-gh-jslocum

@sfc-gh-jslocum sfc-gh-jslocum commented Nov 4, 2022

Copy link
Copy Markdown
Contributor

The cause of the unseed failures for BlobGranule tests with fault injection enabled was the non-determinism in Platform.actor.cpp, caused by this folder not being reset between runs.

Passes 100k BlobGranule* correctness tests with attrition and fault injection enabled with no Unseed mismatches

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Monterey 12.x

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

@sfc-gh-jslocum
sfc-gh-jslocum merged commit bed057e into apple:main Nov 4, 2022
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f991ca6
  • Duration 1:57:27
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

sfc-gh-nwijetunga added a commit to sfc-gh-nwijetunga/foundationdb that referenced this pull request Nov 8, 2022
* main: (67 commits)
  Do not set timeout for RocksDB reads in simulation. (apple#8716)
  Update BlobManager epoc after restore
  Checkpoint restore with shard (apple#8667)
  More nit changes around DD
  Add some comments in DD and fix some nit
  Mako: Initialize Arguments::num_report_files to 0 (apple#8717)
  Use a network option for retaining temporary client lib copies instead of a client knob (apple#8630)
  Fix unintended behavior in Mako (apple#8635)
  Update TLogServer in main
  Change ASSERT_WE_THINK to ASSERT when checking that peek reply start version must be greater than latest pop version
  Apply clang format
  Fix a race condition between batched peek and pop, where the server removal pop may be lost
  revert sys.path placement
  revert sys.path placement
  fixing build vs with that caused compiling aws sdk to not work properly
  Fix /GlobalTagThrottler/TagLimit unit test
  fix update txn options
  moving fdbblob in sim folder for simulations (apple#8701)
  Set minimum average cost to 1 page in GlobalTagThrottler
  Add metrics for read range. (apple#8692)
  ...
sfc-gh-nwijetunga added a commit to sfc-gh-nwijetunga/foundationdb that referenced this pull request Nov 8, 2022
* main: (35 commits)
  Do not set timeout for RocksDB reads in simulation. (apple#8716)
  Update BlobManager epoc after restore
  Checkpoint restore with shard (apple#8667)
  More nit changes around DD
  Add some comments in DD and fix some nit
  Mako: Initialize Arguments::num_report_files to 0 (apple#8717)
  Use a network option for retaining temporary client lib copies instead of a client knob (apple#8630)
  Fix unintended behavior in Mako (apple#8635)
  Update TLogServer in main
  Change ASSERT_WE_THINK to ASSERT when checking that peek reply start version must be greater than latest pop version
  Apply clang format
  Fix a race condition between batched peek and pop, where the server removal pop may be lost
  revert sys.path placement
  revert sys.path placement
  fixing build vs with that caused compiling aws sdk to not work properly
  Fix /GlobalTagThrottler/TagLimit unit test
  fix update txn options
  moving fdbblob in sim folder for simulations (apple#8701)
  Set minimum average cost to 1 page in GlobalTagThrottler
  Add metrics for read range. (apple#8692)
  ...
jzhou77 pushed a commit to jzhou77/foundationdb that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants