fix bg stats invalid access - #8507
Merged
Merged
Conversation
Contributor
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
sfc-gh-anoyes
previously approved these changes
Oct 19, 2022
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2
|
Contributor
Result of foundationdb-pr-macos on macOS Monterey 12.x
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
|
@jzhou77 the failure is unrelated to this change, and this change addresses a memory error coming up in the asan nightly. Can you merge this please? |
sfc-gh-tclinkenbeard
previously approved these changes
Oct 21, 2022
sfc-gh-jslocum
dismissed stale reviews from sfc-gh-tclinkenbeard and sfc-gh-anoyes
via
October 24, 2022 15:14
b46c9dc
sfc-gh-jslocum
force-pushed
the
fix_asan_bg_stats
branch
from
October 24, 2022 15:14
f1d68fb to
b46c9dc
Compare
Contributor
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
sfc-gh-anoyes
approved these changes
Oct 24, 2022
jzhou77
pushed a commit
to jzhou77/foundationdb
that referenced
this pull request
Nov 10, 2022
5 tasks
jzhou77
pushed a commit
to jzhou77/foundationdb
that referenced
this pull request
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect logic on when to add snapshot rows stats
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)