Buggify GRV proxy to return errors and fix bugs found#7844
Merged
Conversation
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
sfc-gh-mpilman
previously approved these changes
Aug 12, 2022
sfc-gh-mpilman
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this
xis19
reviewed
Aug 12, 2022
| self->cx->ssVersionVectorCache.applyDelta(reply.ssVersionVectorDelta); | ||
| return reply.version; | ||
| try { | ||
| GetReadVersionRequest request(span.context, |
Collaborator
There was a problem hiding this comment.
I think this request can be put outside the loop.
Collaborator
Author
There was a problem hiding this comment.
This is intentional. Same request object in an actor can cause old response being replayed, i.e., not delivering new responses.
This turns out to fail a lot of tests that we need to fix.
instead of error_code_proxy_memory_limit_exceeded
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Seeing a CheckRelocation test failed with 300s timeout.
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
sfc-gh-mpilman
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRV proxy may return
proxy_memory_limit_exceededandbatch_transaction_throttlederrors, which are not properly handled at many places.100k 20220811-220634-jzhou-2e8c8744412b8112 passed.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)