Skip to content

Add knobs for min/max Ratekeeper limit#7819

Merged
jzhou77 merged 1 commit into
apple:mainfrom
jzhou77:main
Aug 9, 2022
Merged

Add knobs for min/max Ratekeeper limit#7819
jzhou77 merged 1 commit into
apple:mainfrom
jzhou77:main

Conversation

@jzhou77

@jzhou77 jzhou77 commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

The default has no effects. These knobs can be used in emergency situations with care.

20220808-220133-jzhou-f120af8ec66619d7

Manually updated the knob value and verified RkUpdate events have the limit in effect.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

The default has no effects.
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: e933ac6
  • Duration 1:06:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: e933ac6
  • Duration 1:38:21
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: eba77d7
  • Duration 1:10:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: eba77d7
  • Duration 1:45:49
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests test_ycsb.run. Reason: exit status 2
  • Build Logs (available for 30 days)

@jzhou77 jzhou77 merged commit a907c44 into apple:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants