Skip to content

Fix a crash bug during CC shutdown process#7706

Merged
jzhou77 merged 1 commit into
apple:release-7.1from
jzhou77:release-7.1
Jul 26, 2022
Merged

Fix a crash bug during CC shutdown process#7706
jzhou77 merged 1 commit into
apple:release-7.1from
jzhou77:release-7.1

Conversation

@jzhou77

@jzhou77 jzhou77 commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

cherrypick #7705

actor_cancel should be thrown, otherwise the rest code can access invalid
memory.

100k Status tests 20220726-184853-jzhou-056a987f48e5f7ae

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

actor_cancel should be thrown, otherwise the rest code can access invalid
memory.
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@jzhou77 jzhou77 marked this pull request as ready for review July 26, 2022 18:37
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: be05459
  • Duration 1:06:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: be05459
  • Duration 1:27:52
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@jzhou77 jzhou77 merged commit f252cea into apple:release-7.1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants