Skip to content

Print out unrecovered tags in TLogPoppedTag event#7695

Merged
halfprice merged 1 commit into
apple:mainfrom
halfprice:zhewu/tlog-track-unpopped-recovery-tag
Jul 26, 2022
Merged

Print out unrecovered tags in TLogPoppedTag event#7695
halfprice merged 1 commit into
apple:mainfrom
halfprice:zhewu/tlog-track-unpopped-recovery-tag

Conversation

@halfprice

@halfprice halfprice commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

For easier unrecovered tag identification.

Example output from simulation:

<Event Severity="10" Time="74.919696" DateTime="2022-07-26T03:13:37Z" Type="TLogPoppedTag" Machine="2.0.1.0:1" ID="b6c2579169719573" Tags="6" Tag="-7:0" DurableKCVer="348007463" RecoveredAt="247536981" UnpoppedTags="-7:1,-7:2,-1:2,0:0,0:1,0:2" ThreadID="17612545742900120253" LogGroup="default" Roles="CC,CD,RV,SS,TL" />
<Event Severity="10" Time="74.919696" DateTime="2022-07-26T03:13:37Z" Type="TLogPoppedTag" Machine="2.0.1.0:1" ID="b6c2579169719573" Tags="5" Tag="-7:1" DurableKCVer="348007463" RecoveredAt="247536981" UnpoppedTags="-7:2,-1:2,0:0,0:1,0:2" ThreadID="17612545742900120253" LogGroup="default" Roles="CC,CD,RV,SS,TL" />
<Event Severity="10" Time="74.920235" DateTime="2022-07-26T03:13:37Z" Type="TLogPoppedTag" Machine="2.0.1.0:1" ID="b6c2579169719573" Tags="4" Tag="-7:2" DurableKCVer="348007463" RecoveredAt="247536981" UnpoppedTags="-1:2,0:0,0:1,0:2" ThreadID="17612545742900120253" LogGroup="default" Roles="CC,CD,RV,SS,TL" />
<Event Severity="10" Time="83.810547" DateTime="2022-07-26T03:13:37Z" Type="TLogPoppedTag" Machine="2.0.1.0:1" ID="b6c2579169719573" Tags="3" Tag="-1:2" DurableKCVer="355924697" RecoveredAt="247536981" UnpoppedTags="0:0,0:1,0:2" ThreadID="17612545742900120253" LogGroup="default" Roles="CC,CD,RV,SS,TL" />
<Event Severity="10" Time="83.817134" DateTime="2022-07-26T03:13:37Z" Type="TLogPoppedTag" Machine="2.0.1.0:1" ID="b6c2579169719573" Tags="2" Tag="0:1" DurableKCVer="355924697" RecoveredAt="247536981" UnpoppedTags="0:0,0:2" ThreadID="17612545742900120253" LogGroup="default" Roles="CC,CD,RV,SS,TL" />
<Event Severity="10" Time="83.822607" DateTime="2022-07-26T03:13:37Z" Type="TLogPoppedTag" Machine="2.0.1.0:1" ID="b6c2579169719573" Tags="1" Tag="0:2" DurableKCVer="355924697" RecoveredAt="247536981" UnpoppedTags="0:0" ThreadID="17612545742900120253" LogGroup="default" Roles="CC,CD,RV,SS,TL" />
<Event Severity="10" Time="83.822857" DateTime="2022-07-26T03:13:37Z" Type="TLogPoppedTag" Machine="2.0.1.0:1" ID="b6c2579169719573" Tags="0" Tag="0:0" DurableKCVer="355924697" RecoveredAt="247536981" UnpoppedTags="[no items]" ThreadID="17612545742900120253" LogGroup="default" Roles="CC,CD,RV,SS,TL" />

20220726-012311-zhewu-tlog-recover-tag-9a3b7ad8423eadca compressed=True data_size=34901148 duration=4560691 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=1:02:55 sanity=False started=100097 stopped=20220726-022606 submitted=20220726-012311 timeout=5400 username=zhewu-tlog-recover-tag

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@halfprice
halfprice requested a review from jzhou77 July 25, 2022 23:14
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: a2a4844
  • Duration 0:44:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a2a4844
  • Duration 1:01:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@halfprice
halfprice merged commit 410ad5f into apple:main Jul 26, 2022
@halfprice
halfprice deleted the zhewu/tlog-track-unpopped-recovery-tag branch July 26, 2022 03:10
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a2a4844
  • Duration 4:16:20
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants