Skip to content

Get ShardedRocks ready for simulation test.#7679

Merged
liquid-helium merged 5 commits into
apple:mainfrom
liquid-helium:enable-sharded-rocks-in-simulation
Jul 27, 2022
Merged

Get ShardedRocks ready for simulation test.#7679
liquid-helium merged 5 commits into
apple:mainfrom
liquid-helium:enable-sharded-rocks-in-simulation

Conversation

@liquid-helium

@liquid-helium liquid-helium commented Jul 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Cleaned up ShardedRocks TraceEvent.

Added assertion in ShardManager::validate().

Make sure SHARD_ENCODE_LOCATION_METADATA is enabled in simulation for ShardedRocksDB.

Removed Histogram::getHistogram in reader thread.

Put description here...

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

Disabled tests for ShardedRocks.
8d020e9 
Cleaned up ShardedRocks TraceEvent.

Added assertion in ShardManager::validate().
@foundationdb-ci

foundationdb-ci commented Jul 24, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 8d020e9
  • Duration 0:04:45
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 24, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 8d020e9
  • Duration 0:06:01
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@fdb-windows-ci

fdb-windows-ci commented Jul 24, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Jul 24, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 8d020e9
  • Duration 0:43:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 557d168
  • Duration 0:04:52
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 557d168
  • Duration 0:04:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@fdb-windows-ci

fdb-windows-ci commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@liquid-helium liquid-helium force-pushed the enable-sharded-rocks-in-simulation branch from 557d168 to 01f8021 Compare July 26, 2022 05:41
@liquid-helium liquid-helium changed the title Disabled tests for ShardedRocks. Get ShardedRocks ready for simulation test. Jul 26, 2022
@liquid-helium liquid-helium requested a review from xy-54321 July 26, 2022 05:44
@liquid-helium liquid-helium marked this pull request as ready for review July 26, 2022 05:44
@fdb-windows-ci

fdb-windows-ci commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 557d168
  • Duration 0:43:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 01f8021
  • Duration 1:09:10
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 01f8021
  • Duration 1:37:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

xy-54321
xy-54321 reviewed Jul 26, 2022
View reviewed changes

@xy-54321 xy-54321 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up! Could we make sure that all the trace events include ShardedRocksDB, so we could get all the logs using the keyword?

@liquid-helium liquid-helium requested a review from xy-54321 July 27, 2022 02:50
@liquid-helium liquid-helium force-pushed the enable-sharded-rocks-in-simulation branch from 01f8021 to 8595fe3 Compare July 27, 2022 02:51
@foundationdb-ci

foundationdb-ci commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 8595fe3
  • Duration 0:05:05
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 8595fe3
  • Duration 0:05:10
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@liquid-helium liquid-helium requested a review from halfprice July 27, 2022 03:14
halfprice
halfprice previously approved these changes Jul 27, 2022
View reviewed changes
@liquid-helium liquid-helium force-pushed the enable-sharded-rocks-in-simulation branch from 8595fe3 to d7244c2 Compare July 27, 2022 03:17
@fdb-windows-ci

fdb-windows-ci commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 8595fe3
  • Duration 0:43:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@fdb-windows-ci

fdb-windows-ci commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

foundationdb-ci commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: fd3dc83
  • Duration 1:11:49
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: d7244c2
  • Duration 1:13:17
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@liquid-helium liquid-helium merged commit edbc373 into apple:main Jul 27, 2022
@foundationdb-ci

foundationdb-ci commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: d7244c2
  • Duration 1:32:40
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: fd3dc83
  • Duration 1:42:56
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests test_ycsb.run. Reason: exit status 2
  • Build Logs (available for 30 days)

sfc-gh-nwijetunga added a commit to sfc-gh-nwijetunga/foundationdb that referenced this pull request Jul 27, 2022
@sfc-gh-nwijetunga
Merge branch 'main' of github.com:sfc-gh-nwijetunga/foundationdb into…
50391c3 
… nim/tenant-encryption-property

* 'main' of github.com:sfc-gh-nwijetunga/foundationdb: (42 commits)
  Get ShardedRocks ready for simulation test. (apple#7679)
  fixing specific unit test
  formatting
  addressing review comments
  Fix incorrect deserialization of FdbClientLogEvents::Event (apple#7707)
  Fix a crash bug during CC shutdown process (apple#7705)
  addressing review comments
  remove runAfter
  Add comments explaining the use of the TransactionState tenant() and hasTenant() functions
  Make sure resumeFromDataMoves() starts after resumeFromShards().
  Fix: during recovery, it was possible for tenant operations to briefly fail because the tenant mode is not known
  formatting
  Fixed granule purging bug and improved debugging for purging
  making purge failures fail test
  cleanup and polish
  Bug fix and cleanup
  First version of key-sorted delta files
  Added full granule read unit test
  Completed delta format unit test
  delta file test and delta generation
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neethuhaneesha neethuhaneesha Awaiting requested review from neethuhaneesha
2 more reviewers
@halfprice halfprice halfprice approved these changes
@xy-54321 xy-54321 xy-54321 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liquid-helium @foundationdb-ci @fdb-windows-ci @halfprice @xy-54321