Use key-backed types for tenants#7661
Merged
sfc-gh-abeamon merged 2 commits intoJul 22, 2022
Merged
Conversation
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
a02efec to
4645f6b
Compare
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
…be used in upcoming work. Some other tenant related refactoring.
4645f6b to
17146c4
Compare
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
sfc-gh-jfu
reviewed
Jul 22, 2022
| static inline Key tenantMapPrivatePrefix = "\xff"_sr.withSuffix(tenantMap.subspace.begin); | ||
| }; | ||
|
|
||
| typedef VersionedMap<TenantName, TenantMapEntry> TenantMap; |
Collaborator
There was a problem hiding this comment.
probably not a big concern, but this type name might be a little confusing since the members named tenantMap aren't actually of the TenantMap type
sfc-gh-jfu
previously approved these changes
Jul 22, 2022
… first transaction in deleteTransaction to use on subsequent retries.
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
sfc-gh-jfu
approved these changes
Jul 22, 2022
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds a new
TenantStatefield that will be used in the future metacluster work and does some other refactoring.Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)