Skip to content

Use key-backed types for tenants#7661

Merged
sfc-gh-abeamon merged 2 commits into
apple:mainfrom
sfc-gh-abeamon:tenant-metadata-key-backed-types
Jul 22, 2022
Merged

Use key-backed types for tenants#7661
sfc-gh-abeamon merged 2 commits into
apple:mainfrom
sfc-gh-abeamon:tenant-metadata-key-backed-types

Conversation

@sfc-gh-abeamon

Copy link
Copy Markdown
Collaborator

This also adds a new TenantState field that will be used in the future metacluster work and does some other refactoring.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-abeamon sfc-gh-abeamon marked this pull request as ready for review July 21, 2022 23:36
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a02efec
  • Duration 0:42:53
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: a02efec
  • Duration 0:42:47
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-abeamon sfc-gh-abeamon force-pushed the tenant-metadata-key-backed-types branch from a02efec to 4645f6b Compare July 22, 2022 03:25
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 4645f6b
  • Duration 0:04:50
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 4645f6b
  • Duration 0:04:59
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

…be used in upcoming work. Some other tenant related refactoring.
@sfc-gh-abeamon sfc-gh-abeamon force-pushed the tenant-metadata-key-backed-types branch from 4645f6b to 17146c4 Compare July 22, 2022 03:33
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a02efec
  • Duration 4:17:06
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 17146c4
  • Duration 0:42:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 17146c4
  • Duration 1:02:10
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 17146c4
  • Duration 4:17:32
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

static inline Key tenantMapPrivatePrefix = "\xff"_sr.withSuffix(tenantMap.subspace.begin);
};

typedef VersionedMap<TenantName, TenantMapEntry> TenantMap;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not a big concern, but this type name might be a little confusing since the members named tenantMap aren't actually of the TenantMap type

Comment thread fdbclient/include/fdbclient/TenantManagement.actor.h
Comment thread fdbclient/include/fdbclient/TenantManagement.actor.h
sfc-gh-jfu
sfc-gh-jfu previously approved these changes Jul 22, 2022
… first transaction in deleteTransaction to use on subsequent retries.
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: b735bf8
  • Duration 0:42:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b735bf8
  • Duration 1:13:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-abeamon sfc-gh-abeamon merged commit 9459d0c into apple:main Jul 22, 2022
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b735bf8
  • Duration 4:17:37
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

@sfc-gh-abeamon sfc-gh-abeamon deleted the tenant-metadata-key-backed-types branch July 27, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants