Backups, Azure, Issue 7570: Check existance of container before creation attempt#7641
Merged
Merged
Conversation
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
sfc-gh-tclinkenbeard
approved these changes
Jul 20, 2022
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code adds a workaround for a Segfault appearing deep inside the azure sdk. The code checks for the existence of a
container before attempting creation. This is related to issue #7570
Please note this code is enabled only when -DBUILD_AZURE_BACKUP=ON is turned on via cmake.
Release branches vs Master/main
Master has the affected file inside a subdirectory azure_backup. Release 7.1 branch (the release I am using) has the same file in the parent directory. I will be making a separate pull request for Release 7.1 and Release 7.2 branch.
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)