Skip to content

Backups, Azure, Issue 7570: Check existance of container before creation attempt#7641

Merged
sfc-gh-tclinkenbeard merged 1 commit into
apple:mainfrom
harikb:upstream-clean
Jul 20, 2022
Merged

Backups, Azure, Issue 7570: Check existance of container before creation attempt#7641
sfc-gh-tclinkenbeard merged 1 commit into
apple:mainfrom
harikb:upstream-clean

Conversation

@harikb

@harikb harikb commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

The code adds a workaround for a Segfault appearing deep inside the azure sdk. The code checks for the existence of a
container before attempting creation. This is related to issue #7570

Please note this code is enabled only when -DBUILD_AZURE_BACKUP=ON is turned on via cmake.

Release branches vs Master/main

Master has the affected file inside a subdirectory azure_backup. Release 7.1 branch (the release I am using) has the same file in the parent directory. I will be making a separate pull request for Release 7.1 and Release 7.2 branch.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 3aec508
  • Duration 1:03:35
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-tclinkenbeard sfc-gh-tclinkenbeard merged commit 1020d5b into apple:main Jul 20, 2022
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 3aec508
  • Duration 3:58:11
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
  • Build Logs (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants