Cherry pick 7613 update tag client cache on getKeyLocation#7616
Merged
Conversation
Collaborator
Doxense CI Report for Windows 10
|
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
sbodagala
approved these changes
Jul 19, 2022
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
jzhou77
approved these changes
Jul 19, 2022
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
1inker
pushed a commit
to owtech/foundationdb
that referenced
this pull request
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick PR #7613.
getKeyLocation_internal did not update the SSID->Tag cache when receiving results from the proxy's GetKeyServerLocationsRequest interface. This can result in ssidTagMapping not having information to populate the version vector, in turn resulting in the latest commit version used to fetch data from the SS. This caused waitForVersion to be entered, which can delay responses up to BLOCKING_PEEK_TIMEOUT (currently .4) seconds. If a specific workload from a client is being run this can be indefinite.
Tested running mako and verifying read latency fell back to baseline (non vv) levels.
20220719-152356-henrylambright-1d7ef76da4e02f1dCode-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)