Skip to content

Add StorageEngine type to StorageMetrics trace events (Cherry-pick #7534 to release-7.1)#7546

Merged
jzhou77 merged 1 commit into
apple:release-7.1from
sfc-gh-satherton:storage-type-improvements-7.1
Jul 9, 2022
Merged

Add StorageEngine type to StorageMetrics trace events (Cherry-pick #7534 to release-7.1)#7546
jzhou77 merged 1 commit into
apple:release-7.1from
sfc-gh-satherton:storage-type-improvements-7.1

Conversation

@sfc-gh-satherton

Copy link
Copy Markdown
Collaborator

#7534

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-satherton sfc-gh-satherton requested review from jzhou77, neethuhaneesha and sfc-gh-yiwu and removed request for sfc-gh-yiwu July 7, 2022 23:53
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 4498b94
  • Duration 0:41:06
  • Result: ❌ FAILED
  • Error: Error while executing command: tar -czf "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}/fdb_${FDB_VERSION}.tar.gz" --directory "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}" .. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 4498b94
  • Duration 0:59:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@jzhou77 jzhou77 merged commit a8d0717 into apple:release-7.1 Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants