Skip to content

Cherry pick pull request #7482#7528

Merged
jzhou77 merged 1 commit into
apple:release-7.1from
sbodagala:release-7.1
Jul 6, 2022
Merged

Cherry pick pull request #7482#7528
jzhou77 merged 1 commit into
apple:release-7.1from
sbodagala:release-7.1

Conversation

@sbodagala

@sbodagala sbodagala commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Merge pull request #7482 from sbodagala/main.

Optimize out the version vector specific code on the client (the code that tries to update the version vector on receiving a read version reply from a GRV proxy, and the code in "DatabaseContext::getLatestCommitVersions()") when the version vector feature is disabled.

Testing:
Simulation tests:
Compiler: gcc.
Version vector disabled: 20220706-074612-sre-da2ffe3e53c1d0c8 (no failures).
Version vector enabled: 20220706-092503-sre-006bdedd8e02a4cf (no failures).

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

Optimize out the version vector specific code (on the client) when the feature is disabled
@sbodagala sbodagala requested review from dlambrig and jzhou77 July 6, 2022 09:26
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: c6d541a
  • Duration 0:34:16
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c6d541a
  • Duration 0:37:21
  • Result: ❌ FAILED
  • Error: Error while executing command: tar -czf "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}/fdb_${FDB_VERSION}.tar.gz" --directory "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION} .. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c6d541a
  • Duration 0:50:18
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@dlambrig dlambrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jzhou77 jzhou77 merged commit 3f1b658 into apple:release-7.1 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants