Update EKPServer LookupKeysByKeyIds API#6898
Merged
sfc-gh-ahusain merged 2 commits intoApr 21, 2022
Merged
Conversation
Description Major changes include: 1. Update EKPServer LookupKeysByKeyIds API to include 'encryptDomainId' as input along with 'baseCipherId' 2. Unify EKPServer response definition to return std::vector<EKPBaseCipherDetails> 3. Update SimKmsProxy interfaces as per above mentioned changes. Testing 1. Update EncryptKeyProxyTest simulation test. 2. Update SimEncyrptKeyProxy unit test
Collaborator
Doxense CI Report for Windows 10
|
Contributor
AWS CodeBuild CI Report for macOS BigSur 11.5.2
|
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
sfc-gh-yiwu
reviewed
Apr 20, 2022
5 tasks
Description Major changes include: 1. Update EKPServer LookupKeysByKeyIds API to include 'encryptDomainId' as input along with 'baseCipherId' 2. Unify EKPServer response definition to return std::vector<EKPBaseCipherDetails> 3. Update SimKmsProxy interfaces as per above mentioned changes. Testing 1. Update EncryptKeyProxyTest simulation test. 2. Update SimEncyrptKeyProxy unit test
Collaborator
Doxense CI Report for Windows 10
|
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Major changes include:
'encryptDomainId' as input along with 'baseCipherId'
std::vector
changes.
Testing
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)