Add histogram in GrvProxyServer. by xy-54321 · Pull Request #5278 · apple/foundationdb

xy-54321 · 2021-07-27T01:16:03Z

Add grvConfirmEpochLiveDist and grvRawDist to GrvProxyServer.

j list --stopped | grep  20210730-225754-yaoxiao-c9abab775d808237
20210730-225754-yaoxiao-c9abab775d808237           compressed=True data_size=25963959 duration=5536583 ended=106011 fail_fast=10 max_runs=100000 pass=100002 priority=100 remaining=0 runtime=0:30:21 sanity=False started=106053 stopped=20210730-232815 submitted=20210730-225754 timeout=5400 username=yaoxiao

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

foundationdb-ci · 2021-07-27T01:23:45Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: e07f1ae
Result: FAILED
Build Logs (available for 7 days)

foundationdb-ci · 2021-07-27T02:32:10Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: 67c1388
Result: FAILED
Build Logs (available for 7 days)

foundationdb-ci · 2021-07-27T02:33:20Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build-macos
Commit ID: 67c1388
Result: FAILED
Build Logs (available for 7 days)

foundationdb-ci · 2021-07-27T06:30:27Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: 8ad5fea
Result: FAILED
Build Logs (available for 7 days)

halfprice

Nice!

Can you also post your joshua run result in the PR description?

xy-54321 · 2021-07-28T18:42:56Z

Nice!

Can you also post your joshua run result in the PR description?

I'm having issue connecting to the container. I'll update the result later.

foundationdb-ci · 2021-07-28T19:30:45Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: bd286ae
Result: SUCCEEDED
Build Logs (available for 7 days)

foundationdb-ci · 2021-07-28T19:55:38Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build-macos
Commit ID: bd286ae
Result: SUCCEEDED
Build Logs (available for 7 days)

foundationdb-ci · 2021-07-31T01:00:19Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: 8cbe9e9
Result: FAILED
Build Logs (available for 7 days)

foundationdb-ci · 2021-07-31T01:23:06Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: 82be496
Result: SUCCEEDED
Build Logs (available for 7 days)

xy-54321 · 2021-07-31T01:24:02Z

Added Joshua result and rebased to resolve conflict.

sfc-gh-abeamon · 2021-08-02T15:58:37Z

-	    bucketInterval(FLOW_KNOBS->BASIC_LOAD_BALANCE_UPDATE_RATE / FLOW_KNOBS->BASIC_LOAD_BALANCE_BUCKETS) {
+	    bucketInterval(FLOW_KNOBS->BASIC_LOAD_BALANCE_UPDATE_RATE / FLOW_KNOBS->BASIC_LOAD_BALANCE_BUCKETS),
+	    grvConfirmEpochLiveDist(Histogram::getHistogram(LiteralStringRef("GrvProxy"),
+	                                                    LiteralStringRef("grvConfirmEpochLive"),


Suggested change

LiteralStringRef("grvConfirmEpochLive"),

LiteralStringRef("GrvConfirmEpochLive"),

Did something happen to this? I can't tell from the GitHub history whether this and my other suggestion were applied or not.

I force pushed my local commit, which overwrote the suggestion. I re-applied the change. Please take a look.

foundationdb-ci · 2021-08-04T01:37:40Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: c98c100
Result: FAILED
Build Logs (available for 7 days)

halfprice · 2021-08-04T04:09:13Z

LGTM. Just one request before merging.

The CI failure seems unexpected.

9/11 Test #7: fdbcli_tests ...................................***Failed 19.10 sec
Database created

WARNING: Long delay (Ctrl-C to interrupt)
ERROR: Transaction is too old to perform reads or be committed (1007)
Traceback (most recent call last):
File "/root/src/bindings/python/tests/fdbcli_tests.py", line 441, in
consistencycheck()
File "/root/src/bindings/python/tests/fdbcli_tests.py", line 30, in wrapper
result = func(logger, *args, **kwargs)
File "/root/src/bindings/python/tests/fdbcli_tests.py", line 240, in consistencycheck
assert output1 == consistency_check_on_output
AssertionError
log-dir: /root/src/build_output/tmp/Zpq8KjFEsw3uM4bh/log
etc-dir: /root/src/build_output/tmp/Zpq8KjFEsw3uM4bh/etc
data-dir: /root/src/build_output/tmp/Zpq8KjFEsw3uM4bh/data
cluster-file: /root/src/build_output/tmp/Zpq8KjFEsw3uM4bh/etc/fdb.cluster

This doesn't seem to happen in other PRs. Can you make sure this is not related to your PR?

foundationdb-ci · 2021-08-04T19:02:29Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: 82be496
Result: SUCCEEDED
Build Logs (available for 7 days)

foundationdb-ci · 2021-08-04T19:44:01Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build-macos
Commit ID: 82be496
Result: FAILED
Build Logs (available for 7 days)

Fix applied.

foundationdb-ci · 2021-08-05T00:54:53Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: f3baedd
Result: FAILED
Build Logs (available for 7 days)

foundationdb-ci · 2021-08-05T06:00:08Z

AWS CodeBuild CI Report

CodeBuild project: foundationdb-pull-request-build
Commit ID: f3baedd
Result: FAILED
Build Logs (available for 7 days)

Add histogram in GrvProxyServer.

xy-54321 force-pushed the histogram branch 2 times, most recently from 67c1388 to 8ad5fea Compare July 27, 2021 02:29

halfprice previously approved these changes Jul 27, 2021

View reviewed changes

Comment thread fdbserver/GrvProxyServer.actor.cpp Outdated

halfprice requested a review from xumengpanda July 27, 2021 20:20

halfprice assigned xumengpanda Jul 27, 2021

xy-54321 dismissed halfprice’s stale review via bd286ae July 28, 2021 18:41

xumengpanda assigned halfprice and unassigned xumengpanda Jul 28, 2021

Add histogram in GrvProxyServer.

74a7da0

xy-54321 force-pushed the histogram branch from bd286ae to 8cbe9e9 Compare July 31, 2021 00:56

Updated grvRawDist to grvGetCommittedVersionRpcDist.

82be496

xy-54321 force-pushed the histogram branch from 8cbe9e9 to 82be496 Compare July 31, 2021 01:02

halfprice previously approved these changes Aug 2, 2021

View reviewed changes

sfc-gh-abeamon previously requested changes Aug 2, 2021

View reviewed changes

xy-54321 dismissed halfprice’s stale review via c98c100 August 4, 2021 01:20

xy-54321 requested review from halfprice and sfc-gh-abeamon August 4, 2021 01:23

xy-54321 force-pushed the histogram branch from c98c100 to 82be496 Compare August 4, 2021 18:31

Apply suggestions.

f3baedd

halfprice approved these changes Aug 4, 2021

View reviewed changes

xy-54321 merged commit 876c6d7 into apple:master Aug 4, 2021

xy-54321 deleted the histogram branch August 4, 2021 23:34

xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Sep 27, 2021

Merge pull request apple#5278 from yao-xiao-github/histogram

9fe2bb9

Add histogram in GrvProxyServer.

xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Sep 27, 2021

Merge pull request apple#5278 from yao-xiao-github/histogram

6452a34

Add histogram in GrvProxyServer.

RenxuanW mentioned this pull request Sep 27, 2021

Add histogram in GrvProxyServer (release-7.0). #5676

Merged

5 tasks

RenxuanW pushed a commit that referenced this pull request Sep 27, 2021

Merge pull request #5278 from yao-xiao-github/histogram

a5f3d9c

Add histogram in GrvProxyServer.

xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Sep 28, 2021

Merge pull request apple#5278 from yao-xiao-github/histogram

3eb1728

Add histogram in GrvProxyServer.

xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Sep 28, 2021

Merge pull request apple#5278 from yao-xiao-github/histogram

92c612b

Add histogram in GrvProxyServer.

xy-54321 mentioned this pull request Sep 28, 2021

[cherrypick] Add GRV related histograms. #5689

Merged

5 tasks

xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Sep 28, 2021

Merge pull request apple#5278 from yao-xiao-github/histogram

ca68e9d

Add histogram in GrvProxyServer.

halfprice pushed a commit that referenced this pull request Sep 29, 2021

Merge pull request #5278 from yao-xiao-github/histogram

a891b62

Add histogram in GrvProxyServer.

	LiteralStringRef("grvConfirmEpochLive"),
	LiteralStringRef("GrvConfirmEpochLive"),

Uh oh!

Conversation

xy-54321 commented Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code-Reviewer Section

For Release-Branches

Uh oh!

foundationdb-ci commented Jul 27, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Jul 27, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Jul 27, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Jul 27, 2021

AWS CodeBuild CI Report

Uh oh!

halfprice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xy-54321 commented Jul 28, 2021

Uh oh!

foundationdb-ci commented Jul 28, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Jul 28, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Jul 31, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Jul 31, 2021

AWS CodeBuild CI Report

Uh oh!

xy-54321 commented Jul 31, 2021

Uh oh!

sfc-gh-abeamon Aug 2, 2021

Choose a reason for hiding this comment

Uh oh!

sfc-gh-abeamon Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

xy-54321 Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

foundationdb-ci commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

halfprice commented Aug 4, 2021

Uh oh!

foundationdb-ci commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Aug 5, 2021

AWS CodeBuild CI Report

Uh oh!

foundationdb-ci commented Aug 5, 2021

AWS CodeBuild CI Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xy-54321 commented Jul 27, 2021 •

edited

Loading