Skip to content

Add trace events to print the ranges in ConsistencyCheck. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etschannen merged 1 commit into from
Mar 8, 2018
Merged

Add trace events to print the ranges in ConsistencyCheck. #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fdbserver/workloads/ConsistencyCheck.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,7 @@ struct ConsistencyCheckWorkload : TestWorkload
state Key lastSampleKey;
state Key lastStartSampleKey;
state int64_t totalReadAmount = 0;
state int64_t rangeBytes = 0;

state KeySelector begin = firstGreaterOrEqual(range.begin);

Expand Down Expand Up @@ -725,6 +726,9 @@ struct ConsistencyCheckWorkload : TestWorkload
{
state GetKeyValuesReply current = rangeResult.get();
totalReadAmount += current.data.expectedSize();
if (j == 0) {
rangeBytes += current.data.expectedSize();
}
//If we haven't encountered a valid storage server yet, then mark this as the baseline to compare against
if(firstValidServer == -1)
firstValidServer = j;
Expand Down Expand Up @@ -911,6 +915,8 @@ struct ConsistencyCheckWorkload : TestWorkload
}
}

TraceEvent("ConsistencyCheck_CheckedRange").detail("Range", printable(range)).detail("Bytes", rangeBytes);

canSplit = canSplit && sampledBytes - splitBytes >= shardBounds.min.bytes && sampledBytes > splitBytes;

//Update the size of all storage servers containing this shard
Expand Down