Redwood - Skip page copy for update if page wasn't already cached#4678
Merged
sfc-gh-ngoyal merged 7 commits intoMay 4, 2021
Merged
Conversation
…too high of a performance hit.
…ommitSubtree now does uncacheable reads so it can avoid copying the old version of the page for modification if it was not already in cache.
Contributor
AWS CodeBuild CI Report
|
Contributor
AWS CodeBuild CI Report
|
…edwood-commit-read-uncacheable
sfc-gh-satherton
force-pushed
the
redwood-commit-read-uncacheable
branch
from
fc9df5a to
c891e55
Compare
…edwood-commit-read-uncacheable
Contributor
AWS CodeBuild CI Report
|
Contributor
AWS CodeBuild CI Report
|
| } | ||
|
|
||
| // Try to evict the item at index from cache | ||
| // Returns true if item is evicted or was not present in cache |
Contributor
There was a problem hiding this comment.
Looks like it's returning false for the later case?
Collaborator
Author
There was a problem hiding this comment.
Good catch! I'll fix this.
sfc-gh-satherton
added a commit
to sfc-gh-satherton/foundationdb
that referenced
this pull request
May 6, 2021
sfc-gh-satherton
changed the title
This was referenced Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a page from the pager with the uncacheable flag now returns whether not the page result is from the cache. CommitSubtree uses this to avoid caching a page version that is about to be updated and avoids having to copy the old version for update.
Also added some output improvements to the performance unit test and added a function to the Pager to request a page eviction explicitly.
This PR looks large because it is a descendant of #4616. The final commit has the copy skipping changes.
Passes 100k Redwood unit tests
20210417-025121-satherton_btree-c1870e53bd9b9a18Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormasterif this is the youngest branch)