Skip to content

Don't pass options file to coverage tool#1470

Merged
AlvinMooreSr merged 2 commits into
apple:masterfrom
mpilman:fixes/windows-parallel-build
Apr 19, 2019
Merged

Don't pass options file to coverage tool#1470
AlvinMooreSr merged 2 commits into
apple:masterfrom
mpilman:fixes/windows-parallel-build

Conversation

@mpilman

@mpilman mpilman commented Apr 17, 2019

Copy link
Copy Markdown
Contributor

This hopefully fixes a weird msbuild issue where files are generated
more than once. This issue is described here:
https://gitlab.kitware.com/cmake/cmake/issues/16767

This workaround makes coverage_tool not to use the generated options
files, which hopefully will result in msbuild not trying to generate
these files more than once.

This hopefully fixes a weird msbuild issue where files are generated
more than once. This issue is described here:
https://gitlab.kitware.com/cmake/cmake/issues/16767

This workaround makes coverage_tool not to use the generated options
files, which hopefully will result in msbuild not trying to generate
these files more than once.
@AlvinMooreSr

Copy link
Copy Markdown
Contributor

/MP was a definite winner in allowing the compilation to use parallelism

@AlvinMooreSr AlvinMooreSr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvinMooreSr AlvinMooreSr merged commit 40d632b into apple:master Apr 19, 2019
AlvinMooreSr added a commit to AlvinMooreSr/foundationdb that referenced this pull request Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants