Fix an old exclude failed bug

[jzhou77]

This ensures serverKey map assignment is correct. Without the fix, actors for emptyRangeActors() race with actors that unassign servers, the results depend on the read order. With the fix, ranges are unassigned first, then assigned as empty.

Exclude failed command may corrupt serverKey map. This was found in simulation's DataLossRecovery test and I cherry-pick it for upstream.

[saintstack]

LGTM and also to my 'replacement':

## Correctness assessment

The fix is correct, minimal, and introduces no new defect:

- `actors` / `emptyRangeActors` are freshly scoped per loop iteration.
- `waitForAll` on an empty vector is a no-op (safe when `dest` is empty).
- Phase 2's stale snapshot reads (native `Transaction`, no RYW) don't matter,
  because its writes fully overwrite the range for that `id`.

You are marked as a 'contributor' @jzhou77 ?

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux RHEL 9

• Commit ID: 7fa5321
• Duration 0:21:26
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos-m1 on macOS 14.x

• Commit ID: 7fa5321
• Duration 0:32:37
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-arm on Linux RHEL 9

• Commit ID: 7fa5321
• Duration 0:46:47
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS 14.x

• Commit ID: 7fa5321
• Duration 0:47:01
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux RHEL 9

• Commit ID: 7fa5321
• Duration 0:51:10
• Result: ❌ FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux RHEL 9

• Commit ID: 7fa5321
• Duration 0:55:04
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

• Commit ID: 7fa5321
• Duration 4:00:18
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)