Note that special keys errors must be accessed in the same transaction#13410
Open
nicmorales9 wants to merge 2 commits into
Open
Note that special keys errors must be accessed in the same transaction#13410nicmorales9 wants to merge 2 commits into
nicmorales9 wants to merge 2 commits into
Conversation
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Collaborator
|
This was branched from |
6e9042b to
b430dc2
Compare
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Collaborator
|
Seemingly all failing on this one test, which I haven't seen fail spuriously much before: |
Collaborator
|
Aha, you need to run: |
johscheuer
reviewed
Jun 30, 2026
johscheuer
left a comment
Contributor
There was a problem hiding this comment.
I think it would be worth to provide a code snippet here for users to use, I guess the language doesn't matter too much, just to make sure people get the idea. It might be worth in addition to call out that a user must call Commit() and check the error code from commit before fetching the special key for the error_message.
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The special keys error messages cannot be accessed outside of the transaction that encounters the error.
I was unable to find any documentation referencing this.
This led to an issue in the operator logic FoundationDB/fdb-kubernetes-operator#2514 (though arguably this is more of a problem in the bindings not handling the error for users)
I did some tests on a small cluster to force the not-enough-storage-data error that goes on these keys and found that the message only is get'able inside the same transaction, and several AI interrogations tell me that this is expected based on the code. It also makes sense since technically it could get overwritten quickly and be hard to trace to your tx's specific error, but this should have a note at least.