Skip to content

Check StorageQueueInfo::acceptingRequests in version-lag throttling calculation#12685

Merged
jzhou77 merged 1 commit into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/check-accepting-requests
Feb 10, 2026
Merged

Check StorageQueueInfo::acceptingRequests in version-lag throttling calculation#12685
jzhou77 merged 1 commit into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/check-accepting-requests

Conversation

@tclinkenbeard-oai

Copy link
Copy Markdown
Collaborator

When storage servers restart, we already ignore their storage queue for ratekeeper throttling (because the high storage queue is not caused by workload). We should do the same for version-lag throttling, because the version lag is likewise not caused by workload.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77 jzhou77 closed this Feb 9, 2026
@jzhou77 jzhou77 reopened this Feb 9, 2026
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: f548e4e
  • Duration 0:42:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 0:47:11
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 0:58:06
  • Result: ❌ FAILED
  • Error: Error while executing command: git clone https://github.com/FoundationDB/YCSB.git. Reason: exit status 128
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 1:42:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 1:43:59
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@spraza

spraza commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

@tclinkenbeard-oai tests/restarting/from_7.3.0/ConfigureStorageMigrationTestRestart is failing with [0]. Related to your change?

[0]:

<StorageServerFailed Severity="40" ErrorKind="Unset" Time="4.992692" DateTime="2026-02-0
9T19:14:55Z" Type="StorageServerFailed" Machine="[abcd::2:1:1:0]:1" ID="cb60eaaa48637634" Error="unexpected_encoding_type" ErrorDescription="Page content decoding failed" ErrorCode="1073"

@spraza spraza self-requested a review February 9, 2026 20:24
@tclinkenbeard-oai

Copy link
Copy Markdown
Collaborator Author

@spraza I don't think that failure could be caused by this change, this change will only affect ratekeeper throttling behavior

@spraza spraza closed this Feb 9, 2026
@spraza spraza reopened this Feb 9, 2026
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: f548e4e
  • Duration 0:09:07
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 0:30:03
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: f548e4e
  • Duration 0:43:05
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 0:58:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 1:01:04
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: f548e4e
  • Duration 2:01:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit 88e9736 into apple:main Feb 10, 2026
5 of 6 checks passed
tclinkenbeard-oai added a commit to tclinkenbeard-oai/foundationdb that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants