fix "Unknown error" when configuring regions#11806
Conversation
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
|
Can you rebase your PR with |
97d3077 to
010ed46
Compare
How to rerun CI ? |
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
010ed46 to
1727cda
Compare
|
I rebased PR with apple/main again. Please run CI.
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
|
topic in foundationdb forum about this problem : link |
I ran this test and it passes |
|
@saintstack , I rebased PR with apple/main and fixed code. The tests should now pass. Please run CI. |
| if (isNewDatabase) { | ||
| configString = "new" + configString; | ||
| } else { | ||
| configString.assign(configString.c_str() + 1); |
There was a problem hiding this comment.
Can you use configString.erase(0, 1); here rather than assign, as the intent is clearer and it will handle an empty string.
Can you also add a comment that configureStringFromJSON return string has a leading space.
In the PR, describe how you tested.
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
* fix "Unknown error" when configuring regions * fix "Unknown error" when configuring regions
* fix "Unknown error" when configuring regions * fix "Unknown error" when configuring regions
* fix "Unknown error" when configuring regions * fix "Unknown error" when configuring regions
When executing the command "fdbcli --exec 'fileconfigure..." the error message "ERROR: unknown parameter" is displayed.
The error occurred in
ConfigurationResult buildConfiguration(std::vector const& modeTokens, std::map<std::string, std::string>& outConf);
since the vector of modeTokens included reference to an empty string that got into the vector in the function
ConfigurationResult buildConfiguration(std::string const& configMode, std::map<std::string, std::string>& outConf);
since the configMode begins from empty string which added in
std::string DatabaseConfiguration::configureStringFromJSON(const StatusObject& json)
test.sh:
Result: