Skip to content

Enabling rocksdb direct_io and wiggle knobs #11637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jzhou77 merged 1 commit into from
Sep 19, 2024
Merged

Enabling rocksdb direct_io and wiggle knobs #11637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fdbclient/ServerKnobs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ void ServerKnobs::initialize(Randomize randomize, ClientKnobs* clientKnobs, IsSi
init( PERPETUAL_WIGGLE_DELAY, 60 );
init( PERPETUAL_WIGGLE_SMALL_LOAD_RATIO, 10 );
init( PERPETUAL_WIGGLE_MIN_BYTES_BALANCE_RATIO, 0.85 );
init( PW_MAX_SS_LESSTHAN_MIN_BYTES_BALANCE_RATIO, 0 );
init( PW_MAX_SS_LESSTHAN_MIN_BYTES_BALANCE_RATIO, 8 );
init( PERPETUAL_WIGGLE_DISABLE_REMOVER, true );
init( LOG_ON_COMPLETION_DELAY, DD_QUEUE_LOGGING_INTERVAL );
init( BEST_TEAM_MAX_TEAM_TRIES, 10 );
Expand Down Expand Up @@ -477,7 +477,7 @@ void ServerKnobs::initialize(Randomize randomize, ClientKnobs* clientKnobs, IsSi
init( ROCKSDB_BLOOM_WHOLE_KEY_FILTERING, false );
init( ROCKSDB_MAX_AUTO_READAHEAD_SIZE, 65536 );
// If rocksdb block cache size is 0, the default 8MB is used.
int64_t blockCacheSize = isSimulated ? 16 * 1024 : 4LL * 1024 * 1024 * 1024 /* 4GB */;
int64_t blockCacheSize = isSimulated ? 1LL * 1024 * 1024 * 1024 : 4LL * 1024 * 1024 * 1024 /* 4GB */;
init( ROCKSDB_BLOCK_CACHE_SIZE, blockCacheSize ); /* Datablocks cache + Index&filter blocks cache */
init( ROCKSDB_CACHE_HIGH_PRI_POOL_RATIO, 0.5 ); /* Share of high priority Index&filter blocks in cache */
init( ROCKSDB_CACHE_INDEX_AND_FILTER_BLOCKS, true );
Expand Down Expand Up @@ -570,8 +570,8 @@ void ServerKnobs::initialize(Randomize randomize, ClientKnobs* clientKnobs, IsSi
init( ROCKSDB_WAL_RECOVERY_MODE, 2 ); // kPointInTimeRecovery, RocksDB default.
init( ROCKSDB_TARGET_FILE_SIZE_BASE, 0 ); // If 0, pick RocksDB default.
init( ROCKSDB_TARGET_FILE_SIZE_MULTIPLIER, 1 ); // RocksDB default.
init( ROCKSDB_USE_DIRECT_READS, false );
init( ROCKSDB_USE_DIRECT_IO_FLUSH_COMPACTION, false );
init( ROCKSDB_USE_DIRECT_READS, true );
init( ROCKSDB_USE_DIRECT_IO_FLUSH_COMPACTION, true );
init( ROCKSDB_MAX_OPEN_FILES, -1 ); // RocksDB default.
init( ROCKSDB_USE_POINT_DELETE_FOR_SYSTEM_KEYS, false );
init( ROCKSDB_CF_RANGE_DELETION_LIMIT, 0 );
Expand Down