Skip to content

Fix overflow#11606

Merged
jzhou77 merged 1 commit into
apple:mainfrom
flowguru:fix1
Aug 26, 2024
Merged

Fix overflow#11606
jzhou77 merged 1 commit into
apple:mainfrom
flowguru:fix1

Conversation

@flowguru

Copy link
Copy Markdown
Contributor

uint64_t should be used instead of int

Read from globalconfig: rate=0.010000 size=3621340
VersionStamp is 2181719979
vs1=2181719979
writeRandomKeys finish, written=136
Read from globalconfig: rate=0.010000 size=3621340
VersionStamp is 2284603078
Assertion vs >= previousVS failed @ /root/src/foundationdb/fdbserver/workloads/ClientMetric.actor.cpp 199:

reproduced the issue, and 2181719979 is overflow

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

uint64_t should be used instead of int
@flowguru flowguru requested a review from jzhou77 August 26, 2024 19:15
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 43b9f89
  • Duration 0:07:05
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@spraza spraza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 43b9f89
  • Duration 0:11:44
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@spraza

spraza commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator

Assertion vs >= previousVS failed @ /root/src/foundationdb/fdbserver/workloads/ClientMetric.actor.cpp 199:

It's good that we caught it, but it looks like we got lucky. I wonder if UBSAN would've caught this automatically (it's there in Cmake compiler options, but turned off by default). If you found this issue via sim tests, then probably worthwhile to see if clang sanitizers would help detect this automatically.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 43b9f89
  • Duration 0:22:19
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 43b9f89
  • Duration 0:50:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 43b9f89
  • Duration 0:55:04
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 43b9f89
  • Duration 1:00:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 43b9f89
  • Duration 1:04:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@jzhou77 jzhou77 merged commit 9381d35 into apple:main Aug 26, 2024
@flowguru flowguru mentioned this pull request Aug 27, 2024
5 tasks
@flowguru flowguru deleted the fix1 branch October 13, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants