Fix storage engine selection in simulation#11586
Merged
Merged
Conversation
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the chance of selecting RedWood, which is enforced by encryption feature.
Increase the chance of selecting SQLite, RocksDB, and Memory storage engines.
Benchmark:
We did the test by running 100K correctness tests and dumping the storage engine used in the each simulation. We compare the times of different storage engine selected in the 100K simulations.
Result:
Before change
{'memory-radixtree': 15049, 'ssd-rocksdb-v1': 14639, 'ssd-redwood-1': 23590, 'memory': 15819, 'ssd-2': 21686, 'ssd-sharded-rocksdb': 10580, 'memory-radixtree-beta': 811}
After change
{'ssd-redwood-1': 15488, 'ssd-sharded-rocksdb': 12615, 'ssd-rocksdb-v1': 19120, 'ssd-2': 23428, 'memory': 20454, 'memory-radixtree': 9707, 'memory-radixtree-beta': 595}
100K correctness tests:
20240820-015307-zhewang-4091053e1d8c57b6 compressed=True data_size=37163051 duration=5865514 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:56:00 sanity=False started=100000 stopped=20240820-024907 submitted=20240820-015307 timeout=5400 username=zhewang
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)