Skip to content

Fix storage engine selection in simulation#11586

Merged
kakaiu merged 1 commit into
apple:mainfrom
kakaiu:fix-storage-engine-selection
Aug 20, 2024
Merged

Fix storage engine selection in simulation#11586
kakaiu merged 1 commit into
apple:mainfrom
kakaiu:fix-storage-engine-selection

Conversation

@kakaiu

@kakaiu kakaiu commented Aug 20, 2024

Copy link
Copy Markdown
Member

Reduce the chance of selecting RedWood, which is enforced by encryption feature.
Increase the chance of selecting SQLite, RocksDB, and Memory storage engines.

Benchmark:
We did the test by running 100K correctness tests and dumping the storage engine used in the each simulation. We compare the times of different storage engine selected in the 100K simulations.

Result:
Before change
{'memory-radixtree': 15049, 'ssd-rocksdb-v1': 14639, 'ssd-redwood-1': 23590, 'memory': 15819, 'ssd-2': 21686, 'ssd-sharded-rocksdb': 10580, 'memory-radixtree-beta': 811}

After change
{'ssd-redwood-1': 15488, 'ssd-sharded-rocksdb': 12615, 'ssd-rocksdb-v1': 19120, 'ssd-2': 23428, 'memory': 20454, 'memory-radixtree': 9707, 'memory-radixtree-beta': 595}

100K correctness tests:
20240820-015307-zhewang-4091053e1d8c57b6 compressed=True data_size=37163051 duration=5865514 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:56:00 sanity=False started=100000 stopped=20240820-024907 submitted=20240820-015307 timeout=5400 username=zhewang

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@kakaiu kakaiu requested a review from jzhou77 August 20, 2024 01:41
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 72e7e83
  • Duration 0:06:04
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 72e7e83
  • Duration 0:11:00
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 72e7e83
  • Duration 0:21:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 72e7e83
  • Duration 0:53:10
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 72e7e83
  • Duration 0:55:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 72e7e83
  • Duration 1:01:49
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 72e7e83
  • Duration 1:07:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@jzhou77 jzhou77 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaiu kakaiu merged commit 3305d2e into apple:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants