Fix a couple of simulation failures#11543
Conversation
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
f386793 to
781f6c4
Compare
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
| add_fdb_test( | ||
| TEST_FILES restarting/from_7.3.0/ClientTransactionProfilingCorrectness-1.toml | ||
| restarting/from_7.3.0/ClientTransactionProfilingCorrectness-2.toml) | ||
| TEST_FILES restarting/from_7.3.0_until_7.3.5/ClientTransactionProfilingCorrectness-1.toml | ||
| restarting/from_7.3.0_until_7.3.5/ClientTransactionProfilingCorrectness-2.toml) |
There was a problem hiding this comment.
Remove. I checked https://github.com/FoundationDB/fdb-joshua/blob/main/Dockerfile, where only 7.3.43 and 7.3.27 are listed. So we can ignore 7.3.0 to 7.3.5 here, as they are not supported.
There was a problem hiding this comment.
Ok. One thing to mention here is the 7.3 binary < 7.3.5 does not have the knob dd_physical_shard_move_probability
| ASSERT(SERVER_KNOBS->SHARD_ENCODE_LOCATION_METADATA); | ||
| ASSERT(SERVER_KNOBS->DD_SHARD_USABLE_REGION_CHECK_RATE > 0); | ||
| wait(yieldedFuture(self()->readyToStart.getFuture())); | ||
| double expectedCompletionSeconds = self()->shards->size() * 1.0 / SERVER_KNOBS->DD_SHARD_USABLE_REGION_CHECK_RATE; |
There was a problem hiding this comment.
The comment above says this knob could be set to 0, which, if set, will definitely cause divide by 0 error and the above assertion failure.
There was a problem hiding this comment.
We check the value of DD_SHARD_USABLE_REGION_CHECK_RATE should not be 0 at line 214. This actor is spawned only if DD_SHARD_USABLE_REGION_CHECK_RATE is not 0.
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
This PR includes following fixes:
DD_SHARD_USABLE_REGION_CHECK_RATEto control the speed of triggering data moves.dd_physical_shard_move_probability.100K correctness tests:
20240801-192101-zhewang-1da3aaa415686dc8 compressed=True data_size=37152167 duration=6111521 ended=100000 fail=1 fail_fast=10 max_runs=100000 pass=99999 priority=100 remaining=0 runtime=0:54:45 sanity=False started=100000 stopped=20240801-201546 submitted=20240801-192101 timeout=5400 username=zhewang
Reproduce sharded rocksdb assertion failure at commit ID:
4936acaa7addb946481777730ed7445363c7714f../src/fdbserver-7.3.43 -r simulation -f ../src/foundationdb/tests/restarting/from_7.3.29/ClientTransactionProfilingCorrectness-1.toml --buggify on --seed 3322800254 --logsize 1024MiB
../build_output/bin/fdbserver -r simulation -f ../src/foundationdb/tests/restarting/from_7.3.29/ClientTransactionProfilingCorrectness-2.toml --buggify on --seed 3322800255 --logsize 1024MiB --restarting
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)