Add some debug output for simulation and disable a few blob tests#11540
Merged
Conversation
kakaiu
reviewed
Jul 30, 2024
Member
There was a problem hiding this comment.
Do we want to add some trace event for those printfs? In case the storage engine is rocksdb and the stuck tests cannot be reproduced locally.
We can have a local printf() for the simulation tester which takes the current input and produce both trace events and stdout. This can be involved in a separate PR.
kakaiu
approved these changes
Jul 30, 2024
Contributor
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
spraza
approved these changes
Jul 30, 2024
Contributor
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Collaborator
Author
|
I'll defer the work adding trace events for these printf's. |
xis19
reviewed
Jul 31, 2024
xis19
left a comment
Collaborator
There was a problem hiding this comment.
Maybe we should consider unify the use of:
C++ iostream
fmt library
C stdio
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blob granule tests can take a long time.
20240730-225819-jzhou-649af7f6ee1d65cc
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)