Skip to content

Add some debug output for simulation and disable a few blob tests#11540

Merged
jzhou77 merged 1 commit into
apple:mainfrom
jzhou77:fix
Jul 31, 2024
Merged

Add some debug output for simulation and disable a few blob tests#11540
jzhou77 merged 1 commit into
apple:mainfrom
jzhou77:fix

Conversation

@jzhou77

@jzhou77 jzhou77 commented Jul 30, 2024

Copy link
Copy Markdown
Collaborator

The blob granule tests can take a long time.

20240730-225819-jzhou-649af7f6ee1d65cc

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77 jzhou77 requested a review from kakaiu July 30, 2024 22:56

@kakaiu kakaiu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add some trace event for those printfs? In case the storage engine is rocksdb and the stuck tests cannot be reproduced locally.

We can have a local printf() for the simulation tester which takes the current input and produce both trace events and stdout. This can be involved in a separate PR.

@kakaiu kakaiu self-requested a review July 30, 2024 23:06
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: bbd8900
  • Duration 0:21:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: bbd8900
  • Duration 0:51:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: bbd8900
  • Duration 0:52:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: bbd8900
  • Duration 0:58:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: bbd8900
  • Duration 1:19:03
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77

jzhou77 commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator Author

I'll defer the work adding trace events for these printf's.

@jzhou77 jzhou77 merged commit 5900e66 into apple:main Jul 31, 2024

@xis19 xis19 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider unify the use of:

C++ iostream
fmt library
C stdio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants