Skip to content

Remove assertion equality in tcpvmap size on resolver return#11261

Merged
jzhou77 merged 2 commits into
release-7.3from
release-7.3-clean
Mar 22, 2024
Merged

Remove assertion equality in tcpvmap size on resolver return#11261
jzhou77 merged 2 commits into
release-7.3from
release-7.3-clean

Conversation

@dlambrig

@dlambrig dlambrig commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

Remove assertion on TPCV equality between resolver replies. This commit let only resolver 0 process metadata mutations and generate private mutations, so the assertion is invalid.

@dlambrig
dlambrig requested a review from jzhou77 March 21, 2024 16:09
@dlambrig dlambrig changed the title Release 7.3 clean Remove assertion equality in tcpvmap size on resolver return Mar 21, 2024
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f84d441
  • Duration 0:50:42
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77
jzhou77 requested a review from sbodagala March 21, 2024 17:07
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f84d441
  • Duration 1:22:09
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: f84d441
  • Duration 1:24:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@jzhou77
jzhou77 merged commit f9a42ee into release-7.3 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants