Fix bug in which private mutations were detected incorrectly

[dlambrig]

cherry pick 11236

The resolver logic under PROXY_USE_RESOLVER_PRIVATE_MUTATIONS miscounted the number of private mutations. This led us to write to all TLs when version vector was enabled. The number of mutations can be found by looking at a count in LogPushMutations (subsequence). The bug was this value is initialized to 1, not 0. So to find the count of mutations, 1 must be subtracted.

Verified by enabling version vector, and observing a subset of TLs were selected for the CP to send messages to, rather than all TLs.

Removed version vector upgrade tests pending fix to recovery.

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 63e5031
• Duration 0:07:07
• Result: ❌ FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 63e5031
• Duration 0:07:17
• Result: ❌ FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 63e5031
• Duration 0:47:58
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 75d8625
• Duration 0:06:54
• Result: ❌ FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 75d8625
• Duration 0:08:00
• Result: ❌ FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 75d8625
• Duration 0:49:04
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)

[dlambrig]

seeing this error in build logs, does not seem related to the PR.

Warning, treated as error:
/codebuild/output/src3995441617/src/github.com/apple/foundationdb/documentation/sphinx/source/release-notes/release-notes-730.rst:5:Duplicate explicit target name: "(pr #11043)
".
[830/1791] cd /codebuild/output/src3995441617/src/github.com/apple/foundationdb/build_output/fdbclient/awssdk-build && /usr/local/bin/cmake -DBUILD_SHARED_LIBS=OFF -DENABLE_TES
TING=OFF -DBUILD_ONLY=core -DSIMPLE_INSTALL=ON -DCMAKE_INSTALL_PREFIX=install -DBYO_CRYPTO=ON -DBUILD_CURL=ON -DBUILD_ZLIB=ON -DCMAKE_CXX_COMPILER=/opt/rh/devtoolset-11/root/us
r/bin/c++ -DCMAKE_CXX_FLAGS= -GNinja -S /codebuild/output/src3995441617/src/github.com/apple/foundationdb/build_output/fdbclient/awssdk-src -B /codebuild/output/src3995441617/s
rc/github.com/apple/foundationdb/build_output/fdbclient/awssdk-build && /usr/local/bin/cmake -E touch /codebuild/output/src3995441617/src/github.com/apple/foundationdb/build_ou
tput/fdbclient/awssdk_project-prefix/src/awssdk_project-stamp/awssdk_project-configure
Re-run cmake no build system arguments
CMake Deprecation Warning at CMakeLists.txt:13 (cmake_policy):
  The OLD behavior for policy CMP0077 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.

[foundationdb-ci]

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

• Commit ID: d4ade76
• Duration 0:31:16
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: d4ade76
• Duration 0:49:42
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: d4ade76
• Duration 1:03:59
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: d4ade76
• Duration 1:07:17
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)