Skip to content

Merge pull request #11091#11093

Merged
jzhou77 merged 1 commit into
apple:release-7.1from
sbodagala:release-7.1
Dec 8, 2023
Merged

Merge pull request #11091#11093
jzhou77 merged 1 commit into
apple:release-7.1from
sbodagala:release-7.1

Conversation

@sbodagala

@sbodagala sbodagala commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

Address issues in code related to "fdbcli checkall" command.

Merge pull request #11091 from sbodagala/main.

Testing:

Joshua job: 20231207-224540-sre-446191fe84ef2154 (started).

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

Address issues in code related to "fdbcli checkall" command
@sbodagala sbodagala requested a review from jzhou77 December 7, 2023 22:43
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a7bad66
  • Duration 0:07:53
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a7bad66
  • Duration 0:08:44
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: a7bad66
  • Duration 0:09:21
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: a7bad66
  • Duration 0:16:23
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: a7bad66
  • Duration 0:43:44
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@jzhou77 jzhou77 requested a review from flowguru December 8, 2023 00:23
@sbodagala

Copy link
Copy Markdown
Contributor Author

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a7bad66
  • Duration 0:08:44
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

From the build log:

CMake Error at /codebuild/output/src3059212568/src/github.com/apple/foundationdb/build_output/fdbserver/rocksdb-prefix/src/rocksdb-stamp/rocksdb-build-Release.cmake:49 (message):
Command failed: 1

'/usr/local/bin/cmake' '--build' '.'

See also

/codebuild/output/src3059212568/src/github.com/apple/foundationdb/build_output/fdbserver/rocksdb-prefix/src/rocksdb-stamp/rocksdb-build-*.log

@jzhou77 jzhou77 merged commit 6b5e96d into apple:release-7.1 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants