[Release-7.3] Cherry-pick Add write traffic metrics to ddMetricsGetRange#10998
Merged
kakaiu merged 1 commit intoOct 20, 2023
Conversation
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Member
Author
|
foundationdb-pr-cluster-tests on Linux CentOS 7 is failed due to the timeout of getting FDB status through the operator Pod. |
jzhou77
approved these changes
Oct 20, 2023
dlambrig
approved these changes
Oct 20, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #10987.
100K correctness test:
20231019-182456-zhewang-0cfefafa39a1fe2a compressed=True data_size=34493324 duration=8175372 ended=100000 fail=2 fail_fast=10 max_runs=100000 pass=99998 priority=100 remaining=0 runtime=1:07:20 sanity=False started=100000 stopped=20231019-193216 submitted=20231019-182456 timeout=5400 username=zhewang
1 failure is external timeout with rocksdb storage engine in a restart test.
1 failure is a shared tLog failure in
tests/rare/DcLag.toml:<SharedTLogFailed Severity="40" ErrorKind="DiskIssue" Time="315.123440" DateTime="2023-10-19T19:13:15Z" Type="SharedTLogFailed" Machine="2.2.1.1:1" ID="a77c36aeb3b94777" Error="io_error" ErrorDescription="Disk i/o operation failed" ErrorCode="1510" Reason="Error" ThreadID="14335352005369276283" Backtrace="cd /root/build_output/bin; addr2line -e fdbserver -p -C -f -i 0x5401c0d 0x5401ed3 0x53fc0d4 0x34a432d 0x34d4756 0x34d435e 0x34d2422 0x34d2766 0x1b61039 0x34d353d 0x34d2909 0x209c4a8 0x209c916 0x1b61039 0x34d353d 0x34d2909 0x209c4a8 0x209c916 0x1b61039 0x3054d10 0x30548c9 0x1b61039 0x530e4f4 0x530d9a1 0x530dd67 0x1b61039 0x2ac9293 0x2ac9589 0x1b61039 0x305396a 0x1b61039 0x3045811 0x3045bb7 0x1b61039 0x530e4f4 0x530d9a1 0x530dd67 0x1b61039 0x3041d6a 0x1b61039 0x1f3e0f9 0x2718aa0 0x1f3e0f9 0x2717454 0x2717f48 0x27..." LogGroup="default"/>To the best of my knowledge, the two failures should not be relevant to this PR @dlambrig @jzhou77
Tested in Kubernetes cluster.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)