[Release-7.1] Add write traffic metrics to ddMetricsGetRange#10985
Merged
jzhou77 merged 1 commit intoOct 16, 2023
Conversation
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-clang on Linux CentOS 7
|
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
jzhou77
approved these changes
Oct 16, 2023
liquid-helium
approved these changes
Oct 16, 2023
This was referenced Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users get shard write traffic and bytes by
getrange "\xff\xff/metrics/data_distribution_stats/<shardbegin>" "\xff\xff/metrics/data_distribution_stats/<shardend>"Correctness test with 2 irrelevant failures:
20231016-174827-zhewang-654839c5d6f9aaa1 compressed=True data_size=24138808 duration=5091577 ended=100000 fail=2 fail_fast=10 max_runs=100000 pass=99998 priority=100 remaining=0 runtime=0:54:44 sanity=False started=100000 stopped=20231016-184311 submitted=20231016-174827 timeout=5400 username=zhewang
Checked by Kubernetes test
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)