Repository navigation
feat(viewer): enable persistent label caching in the online file viewer - #302
Open
utkarshpatwa393-sys wants to merge 1 commit into
Open
utkarshpatwa393-sys wants to merge 1 commit into
utkarshpatwa393-sys wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169
Summary
createBrowserCache,createMemoryCache, anddatasetCacheNamespaceinpackages/viewer/src/utils/browser_cache.ts(IndexedDB-backed bounded LRU cache with an in-memory mirror/fallback when IndexedDB is unavailable or blocked).cacheintoFileViewer.svelteso the online "Load Data" viewer reuses cached cluster labels:createBrowserCache(datasetCacheNamespace(inputs)), scoping entries by URL or file metadata (name,size,lastModified) so distinct datasets loading into table"dataset"do not collide.createMemoryCache()for the active session so layout switches/remounts avoid recomputation without persisting labels from one UMAP run to a future run.EmbeddingAtlasStore.chartContext.persistentCachetocreateMemoryCache()whenoptions.cacheis omitted so embedded instances also reuse cached labels within a session.Verification
npm run test -w @embedding-atlas/utils -w @embedding-atlas/viewer(@embedding-atlas/utils: 124 passed;@embedding-atlas/viewer: 149 passed including 5 new tests inpackages/viewer/test/browser_cache.test.ts)npx prettier -c .(all matched files pass)npm run test:versions(all versions match0.26.0)