Skip to content

ContainerizationOCI: raise Reference name limit to 255 to match OCI spec #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcantah merged 1 commit into from
Feb 20, 2026
+19 −2
Merged

ContainerizationOCI: raise Reference name limit to 255 to match OCI spec #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/ContainerizationOCI/Reference.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,13 @@
import ContainerizationError
import Foundation

private let referenceTotalLengthMax = 255
private let nameTotalLengthMax = 127
// nameTotalLengthMax matches the OCI distribution spec which allows up to 255 bytes for the
// repository name component (domain + "/" + path).
private let nameTotalLengthMax = 255
// referenceTotalLengthMax is the upper bound for the full reference string: max name (255) +
// separator (1) + max tag length (128) = 384.
private let tagLengthMax = 128
private let referenceTotalLengthMax = nameTotalLengthMax + 1 + tagLengthMax
private let legacyDockerRegistryHost = "docker.io"
private let dockerRegistryHost = "registry-1.docker.io"
private let defaultDockerRegistryRepo = "library"
Expand Down
12 changes: 12 additions & 0 deletions Tests/ContainerizationOCITests/ReferenceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,16 @@ struct ReferenceParseTests {
digest: "sha256:\(String(repeating: "abcd", count: 16))"),
ReferenceParseTestCase(input: "192.168.1.1:5544/local/swift:6.0", domain: "192.168.1.1:5544", path: "local/swift", tag: "6.0"),
ReferenceParseTestCase(input: "[abc12::4]:5683/swift", domain: "[abc12::4]:5683", path: "swift"),
// Verify names longer than 127 characters are accepted (OCI spec allows up to 255).
ReferenceParseTestCase(
input: "reg.io/\(String(repeating: "a", count: 121))",
domain: "reg.io",
path: String(repeating: "a", count: 121)),
// Verify a name of exactly 255 characters (the OCI spec maximum) is accepted.
ReferenceParseTestCase(
input: "registry.example.com/\(String(repeating: "a", count: 234))",
domain: "registry.example.com",
path: String(repeating: "a", count: 234)),
])
func validReferenceParse(testCase: ReferenceParseTestCase) async throws {
#expect(throws: Never.self) {
Expand All @@ -81,6 +91,8 @@ struct ReferenceParseTests {
"[abc12::4]:abc12::4",
"[2001:db8:3:4::192.0.2.33]:5000/debian",
"1a3f5e7d9c1b3a5f7e9d1c3b5a7f9e1d3c5b7a9f1e3d5d7c9b1a3f5e7d9c1b3a",
// A name of 256 characters exceeds the OCI spec limit of 255 and must be rejected.
"registry.example.com/\(String(repeating: "a", count: 235))",
])
func invalidReferenceParse(input: String) async throws {
#expect(throws: ContainerizationError.self) {
Expand Down