Repository navigation
Fix: index alignment - #82
Merged
Merged
Conversation
…or database context initialization and add tests for ExecutionGroup and PreferredNode properties across MySQL, PostgreSQL, SQLite, and SQL Server.
…ny#76) All four providers shipped the legacy PostgreSQL index set (pre Quartz 3.20). Replace it with the 4.0.1 set, which is identical across providers: J_G_N, T_J, T_G_N, T_C, T_NFT_ST (SCHED_NAME, TRIGGER_STATE, NEXT_FIRE_TIME, PRIORITY DESC, MISFIRE_INSTR), FT_INST_JOB_REQ_RCVRY, FT_J_G, FT_T_G. Upgrading from 0.6.1 drops 10 indexes, renames 2 (incl. the EF foreign key index to T_J) and creates 6. Verified against SQL Server, PostgreSQL, MySQL (Pomelo and Oracle provider) and SQLite. Fixes appany#76
Member
|
Hey @MJECloud! Could you please take a look at the merge conflicts? |
Contributor
Author
|
Hi @sergeyshaykhullin conflicts are resolved. Thanks for looking so fast into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76
This pull request updates the Entity Framework Core model mappings for all supported database providers to align with the Quartz.NET 4.0.1 schema, specifically modernizing and standardizing index definitions and adding comprehensive tests to verify column and index mappings. The changes ensure that the generated tables and indexes match the official Quartz.NET scripts, improving compatibility and maintainability.
The most important changes are:
Index Standardization and Alignment with Quartz.NET 4.0.1:
QuartzTrigger,QuartzJobDetail, andQuartzFiredTriggerto match the Quartz.NET 4.0.1 schema for MySQL, PostgreSQL, SQLite, and SQL Server providers. This includes renaming, removing legacy indexes, and reshaping composite indexes, such as the new structure forIDX_QRTZ_T_NFT_ST, and ensuring correct column order and sort direction. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Documentation Updates:
README.mdto document the index changes, including migration guidance and provider-specific notes, such as the importance of maintenance windows and index usage in MySQL.Testing Enhancements:
QuartzTriggerModelMappingTestsfor MySQL and PostgreSQL to verify that all columns (including new ones likeExecutionGroup,PreferredNode, etc.) and indexes are mapped as expected, directly comparing the model to the Quartz.NET schema. [1] [2]These updates ensure the EF Core migrations are fully compatible with Quartz.NET 4.0.1 and that future changes will be caught by the improved test coverage.