Conversation
myovchev
force-pushed
the
static-build
branch
from
eb90221 to
cc8e12d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
See above for my thoughts.
| // values are emitted into the virtual config module so that | ||
| // helpers and library code never need to re-check process.env. | ||
| resolvedAposHost = process.env.APOS_HOST || options.aposHost; | ||
| const aposPrefix = process.env.APOS_PREFIX |
There was a problem hiding this comment.
APOS_PREFIX is a VERY nice nice-to-have. I see it let you do github sites.
There was a problem hiding this comment.
It's currently supported on a project level, I didn't change core to apply prefix based on env.
|
|
||
| dispatchAll() { | ||
| self.dispatch('/', self.indexPage); | ||
| if (self.apos.url.options.static) { |
There was a problem hiding this comment.
A question. This flag will be set when the dynamic editing site intended for static builds later is being edited right? It's best if URLs are built the same between the two.
There was a problem hiding this comment.
But we could temporarily live without that if we must do so in order to release this on time.
There was a problem hiding this comment.
The build can't be initiated if this flag is not set. So basically - yes, it's indirectly enforced. There will be some differences how internal URLs will be built, but the major links - pagination, filters, etc should be the same.
4 participants
Summary
Introduced static build support via external frontend.